Ernest Romero Climent
|
93392fc149
|
Fix terminal state and key state data races (#335)
* Update gitignore to ignore .swp
* Fix terminal state data races
go run -race cmd/darktile/main.go
WARNING: DATA RACE
Write at 0x00c000864128 by goroutine 23:
github.com/liamg/darktile/internal/app/darktile/termutil.(*Terminal).sgrSequenceHandler()
/home/ernestrc/src/darktile/internal/app/darktile/termutil/csi.go:973 +0x12ca
github.com/liamg/darktile/internal/app/darktile/termutil.(*Terminal).handleCSI()
/home/ernestrc/src/darktile/internal/app/darktile/termutil/csi.go:62 +0x7e8
github.com/liamg/darktile/internal/app/darktile/termutil.(*Terminal).handleANSI()
/home/ernestrc/src/darktile/internal/app/darktile/termutil/ansi.go:11 +0xc86
github.com/liamg/darktile/internal/app/darktile/termutil.(*Terminal).process()
/home/ernestrc/src/darktile/internal/app/darktile/termutil/terminal.go:206 +0x126
github.com/liamg/darktile/internal/app/darktile/termutil.(*Terminal).Run·dwrap·10()
/home/ernestrc/src/darktile/internal/app/darktile/termutil/terminal.go:171 +0x39
Previous read at 0x00c000864128 by goroutine 22:
[failed to restore the stack]
Goroutine 23 (running) created at:
github.com/liamg/darktile/internal/app/darktile/termutil.(*Terminal).Run()
/home/ernestrc/src/darktile/internal/app/darktile/termutil/terminal.go:171 +0x517
github.com/liamg/darktile/internal/app/darktile/gui.(*GUI).Run.func1()
/home/ernestrc/src/darktile/internal/app/darktile/gui/gui.go:80 +0xa
Goroutine 22 (running) created at:
github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw.(*UserInterface).Run()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw/run_notsinglethread.go:37 +0x2c4
github.com/hajimehoshi/ebiten/v2.RunGame()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/run.go:158 +0x1d4
github.com/liamg/darktile/internal/app/darktile/gui.(*GUI).Run()
/home/ernestrc/src/darktile/internal/app/darktile/gui/gui.go:99 +0x2de
github.com/liamg/darktile/internal/app/darktile/cmd.glob..func2()
/home/ernestrc/src/darktile/internal/app/darktile/cmd/root.go:130 +0x13a9
github.com/spf13/cobra.(*Command).execute()
/home/ernestrc/src/darktile/vendor/github.com/spf13/cobra/command.go:852 +0xa7d
github.com/spf13/cobra.(*Command).ExecuteC()
/home/ernestrc/src/darktile/vendor/github.com/spf13/cobra/command.go:960 +0x5da
github.com/spf13/cobra.(*Command).Execute()
/home/ernestrc/src/darktile/vendor/github.com/spf13/cobra/command.go:897 +0x366
github.com/liamg/darktile/internal/app/darktile/cmd.Execute()
/home/ernestrc/src/darktile/internal/app/darktile/cmd/root.go:153 +0x34f
main.main()
/home/ernestrc/src/darktile/cmd/darktile/main.go:75 +0x24
==================
Found 26 data race(s)
* Fix KeyPressed data race
go run -race cmd/darktile/main.go
WARNING: DATA RACE
Write at 0x00c00009fbc0 by goroutine 20:
runtime.mapdelete_fast64()
/usr/lib/go/src/runtime/map_fast64.go:272 +0x0
github.com/liamg/darktile/internal/app/darktile/gui.(*keyState).RepeatPressed()
/home/ernestrc/src/darktile/internal/app/darktile/gui/key_states.go:61 +0x428
github.com/liamg/darktile/internal/app/darktile/gui.(*GUI).handleInput()
/home/ernestrc/src/darktile/internal/app/darktile/gui/input.go:109 +0x224
github.com/liamg/darktile/internal/app/darktile/gui.(*GUI).Update()
/home/ernestrc/src/darktile/internal/app/darktile/gui/update.go:34 +0x2e
github.com/hajimehoshi/ebiten/v2.(*imageDumper).update()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/imagedumper_desktop.go:111 +0x85
github.com/hajimehoshi/ebiten/v2.(*imageDumperGame).Update()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/run.go:115 +0x172
github.com/hajimehoshi/ebiten/v2.(*uiContext).updateImpl()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/uicontext.go:194 +0x12c
github.com/hajimehoshi/ebiten/v2.(*uiContext).update()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/uicontext.go:166 +0x88
github.com/hajimehoshi/ebiten/v2.(*uiContext).Update()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/uicontext.go:147 +0x3b
github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw.(*UserInterface).loop()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw/ui.go:1036 +0x401
github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw.(*UserInterface).Run.func1()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw/run_notsinglethread.go:53 +0x1b1
Previous read at 0x00c00009fbc0 by goroutine 19:
github.com/liamg/darktile/internal/app/darktile/gui.(*keyState).AnythingPressed()
/home/ernestrc/src/darktile/internal/app/darktile/gui/key_states.go:33 +0xbc
github.com/liamg/darktile/internal/app/darktile/gui.(*GUI).watchForUpdate()
/home/ernestrc/src/darktile/internal/app/darktile/gui/gui.go:105 +0x77
github.com/liamg/darktile/internal/app/darktile/gui.(*GUI).Run·dwrap·2()
/home/ernestrc/src/darktile/internal/app/darktile/gui/gui.go:97 +0x39
Goroutine 20 (running) created at:
github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw.(*UserInterface).Run()
/home/ernestrc/src/darktile/vendor/github.com/hajimehoshi/ebiten/v2/internal/uidriver/glfw/run_notsinglethread.go:37 +0x2c4
github.com/hajimehoshi/ebiten/v2.RunGame()
Goroutine 19 (running) created at:
github.com/liamg/darktile/internal/app/darktile/gui.(*GUI).Run()
/home/ernestrc/src/darktile/internal/app/darktile/gui/gui.go:97 +0x2ca
github.com/liamg/darktile/internal/app/darktile/cmd.glob..func2()
/home/ernestrc/src/darktile/internal/app/darktile/cmd/root.go:130 +0x13a9
github.com/spf13/cobra.(*Command).execute()
/home/ernestrc/src/darktile/vendor/github.com/spf13/cobra/command.go:852 +0xa7d
github.com/spf13/cobra.(*Command).ExecuteC()
/home/ernestrc/src/darktile/vendor/github.com/spf13/cobra/command.go:960 +0x5da
github.com/spf13/cobra.(*Command).Execute()
/home/ernestrc/src/darktile/vendor/github.com/spf13/cobra/command.go:897 +0x366
github.com/liamg/darktile/internal/app/darktile/cmd.Execute()
/home/ernestrc/src/darktile/internal/app/darktile/cmd/root.go:153 +0x34f
main.main()
/home/ernestrc/src/darktile/cmd/darktile/main.go:75 +0x24
|
2022-05-10 09:18:01 +01:00 |
Liam Galvin
|
62453daa17
|
Fix stupid input bug (#330)
* Fix stupid input bug
* Fix build
|
2021-12-17 09:27:35 +00:00 |
Qiu
|
97b6a41eb3
|
Make getting the up-time more portable across unix-like systems (#326)
* Make getting the up-time more portable across unix-like systems
* Fix the build on NetBSD
* Update Go version in workflows
|
2021-12-17 08:39:48 +00:00 |
|
Qiu
|
47c91e0002
|
Make build and install scripts more portable (#325)
|
2021-12-17 08:38:59 +00:00 |
|
Liam Galvin
|
41f8406484
|
Fix font loading for home dirs (#309)
* Update fontinfo to v0.1.1
* Fix font loading
|
2021-08-04 21:01:31 +01:00 |
|
Liam Galvin
|
e492e6ea90
|
Update fontinfo to v0.1.1 (#305)
|
2021-08-02 21:04:03 +01:00 |
|
Liam Galvin
|
765a781055
|
Add support for ligatures, cursor shapes (and images) (#304)
|
2021-08-02 20:55:04 +01:00 |
|
Liam Galvin
|
c18b702b61
|
Fix issues with transparency (#301)
* Fix issues with transparency
* Dispose of temporary alpha image
|
2021-07-31 17:35:26 +01:00 |
|
Liam Galvin
|
8d4ea4d7fe
|
docs: Fix merge
|
2021-07-31 14:38:49 +01:00 |
|
Liam Galvin
|
05e7618fa1
|
docs: Add installation steps + script (#300)
* docs: Add installation steps + script
|
2021-07-31 14:38:41 +01:00 |
|
Liam Galvin
|
6fa6998aca
|
docs: Add installation steps + script
|
2021-07-31 14:35:27 +01:00 |
|
Liam Galvin
|
1f2980cbb4
|
Persist mouse mode during buffer switching (#299)
* Persist mouse mode during buffer switching
* Update mouse.go
|
2021-07-31 14:34:02 +01:00 |
|
Liam Galvin
|
80b4d6ac9c
|
Improve mouse handling (#298)
|
2021-07-31 13:56:39 +01:00 |
|
Liam Galvin
|
d1a7b7d6a1
|
Don't save terminal state if the process was launched from a non-tty, e.g. WM
|
2021-07-31 13:40:52 +01:00 |
|
Liam Galvin
|
d99bdd3bb2
|
Create LICENSE
|
2021-07-31 08:45:31 +01:00 |
|
Liam Galvin
|
466f8ea344
|
Create FUNDING.yml
|
2021-07-31 08:35:56 +01:00 |
|
Liam Galvin
|
aaa8cf2120
|
Update README.md
|
2021-07-31 00:06:37 +01:00 |
|
Liam Galvin
|
cc8a784b6a
|
Update README.md
|
2021-07-30 23:58:50 +01:00 |
|
Liam Galvin
|
ff91399d6d
|
Update README.md
|
2021-07-30 23:57:31 +01:00 |
|
Liam Galvin
|
569df2ca95
|
Fix goreleaser
|
2021-07-30 23:52:34 +01:00 |
|
Liam Galvin
|
50d838e959
|
fix goreleaser
|
2021-07-30 23:47:18 +01:00 |
|
Liam Galvin
|
a15ec9b335
|
fix goreleaser
|
2021-07-30 23:40:41 +01:00 |
|
Liam Galvin
|
e60a0b0427
|
Initial commit
|
2021-07-30 23:29:20 +01:00 |