package main import ( "bytes" "fmt" "net/http/httptest" "runtime/debug" "strconv" "testing" "time" "./common" ) func recordMustExist(t *testing.T, err error, errmsg string, args ...interface{}) { if err == ErrNoRows { debug.PrintStack() t.Errorf(errmsg, args...) } else if err != nil { debug.PrintStack() t.Fatal(err) } } func recordMustNotExist(t *testing.T, err error, errmsg string, args ...interface{}) { if err == nil { debug.PrintStack() t.Errorf(errmsg, args...) } else if err != ErrNoRows { debug.PrintStack() t.Fatal(err) } } func TestUserStore(t *testing.T) { if !gloinited { err := gloinit() if err != nil { t.Fatal(err) } } if !common.PluginsInited { common.InitPlugins() } var err error ucache := common.NewMemoryUserCache(common.Config.UserCacheCapacity) common.Users, err = common.NewDefaultUserStore(ucache) expectNilErr(t, err) ucache.Flush() userStoreTest(t, 2) common.Users, err = common.NewDefaultUserStore(nil) expectNilErr(t, err) userStoreTest(t, 5) } func userStoreTest(t *testing.T, newUserID int) { ucache := common.Users.GetCache() // Go doesn't have short-circuiting, so this'll allow us to do one liner tests isCacheLengthZero := func(ucache common.UserCache) bool { if ucache == nil { return true } return ucache.Length() == 0 } cacheLength := func(ucache common.UserCache) int { if ucache == nil { return 0 } return ucache.Length() } expect(t, isCacheLengthZero(ucache), fmt.Sprintf("The initial ucache length should be zero, not %d", cacheLength(ucache))) _, err := common.Users.Get(-1) recordMustNotExist(t, err, "UID #-1 shouldn't exist") expect(t, isCacheLengthZero(ucache), fmt.Sprintf("We found %d items in the user cache and it's supposed to be empty", cacheLength(ucache))) _, err = common.Users.Get(0) recordMustNotExist(t, err, "UID #0 shouldn't exist") expect(t, isCacheLengthZero(ucache), fmt.Sprintf("We found %d items in the user cache and it's supposed to be empty", cacheLength(ucache))) user, err := common.Users.Get(1) recordMustExist(t, err, "Couldn't find UID #1") var expectW = func(cond bool, expec bool, prefix string, suffix string) { midfix := "should not be" if expec { midfix = "should be" } expect(t, cond, prefix+" "+midfix+" "+suffix) } // TODO: Add email checks too? Do them seperately? var expectUser = func(user *common.User, uid int, name string, group int, super bool, admin bool, mod bool, banned bool) { expect(t, user.ID == uid, fmt.Sprintf("user.ID should be %d. Got '%d' instead.", uid, user.ID)) expect(t, user.Name == name, fmt.Sprintf("user.Name should be '%s', not '%s'", name, user.Name)) expectW(user.Group == group, true, user.Name, "in group"+strconv.Itoa(group)) expectW(user.IsSuperAdmin == super, super, user.Name, "a super admin") expectW(user.IsAdmin == admin, admin, user.Name, "an admin") expectW(user.IsSuperMod == mod, mod, user.Name, "a super mod") expectW(user.IsMod == mod, mod, user.Name, "a mod") expectW(user.IsBanned == banned, banned, user.Name, "banned") } expectUser(user, 1, "Admin", 1, true, true, true, false) _, err = common.Users.Get(newUserID) recordMustNotExist(t, err, fmt.Sprintf("UID #%d shouldn't exist", newUserID)) if ucache != nil { expectIntToBeX(t, ucache.Length(), 1, "User cache length should be 1, not %d") _, err = ucache.Get(-1) recordMustNotExist(t, err, "UID #-1 shouldn't exist, even in the cache") _, err = ucache.Get(0) recordMustNotExist(t, err, "UID #0 shouldn't exist, even in the cache") user, err = ucache.Get(1) recordMustExist(t, err, "Couldn't find UID #1 in the cache") expect(t, user.ID == 1, fmt.Sprintf("user.ID does not match the requested UID. Got '%d' instead.", user.ID)) expect(t, user.Name == "Admin", fmt.Sprintf("user.Name should be 'Admin', not '%s'", user.Name)) _, err = ucache.Get(newUserID) recordMustNotExist(t, err, "UID #%d shouldn't exist, even in the cache", newUserID) ucache.Flush() expectIntToBeX(t, ucache.Length(), 0, "User cache length should be 0, not %d") } // TODO: Lock onto the specific error type. Is this even possible without sacrificing the detailed information in the error message? var userList map[int]*common.User userList, _ = common.Users.BulkGetMap([]int{-1}) expect(t, len(userList) == 0, fmt.Sprintf("The userList length should be 0, not %d", len(userList))) expect(t, isCacheLengthZero(ucache), fmt.Sprintf("User cache length should be 0, not %d", cacheLength(ucache))) userList, _ = common.Users.BulkGetMap([]int{0}) expect(t, len(userList) == 0, fmt.Sprintf("The userList length should be 0, not %d", len(userList))) expect(t, isCacheLengthZero(ucache), fmt.Sprintf("User cache length should be 0, not %d", cacheLength(ucache))) userList, _ = common.Users.BulkGetMap([]int{1}) expect(t, len(userList) == 1, fmt.Sprintf("Returned map should have one result (UID #1), not %d", len(userList))) user, ok := userList[1] if !ok { t.Error("We couldn't find UID #1 in the returned map") t.Error("userList", userList) return } expect(t, user.ID == 1, fmt.Sprintf("user.ID does not match the requested UID. Got '%d' instead.", user.ID)) if ucache != nil { expectIntToBeX(t, ucache.Length(), 1, "User cache length should be 1, not %d") user, err = ucache.Get(1) recordMustExist(t, err, "Couldn't find UID #1 in the cache") expect(t, user.ID == 1, fmt.Sprintf("user.ID does not match the requested UID. Got '%d' instead.", user.ID)) ucache.Flush() } expect(t, !common.Users.Exists(-1), "UID #-1 shouldn't exist") expect(t, !common.Users.Exists(0), "UID #0 shouldn't exist") expect(t, common.Users.Exists(1), "UID #1 should exist") expect(t, !common.Users.Exists(newUserID), fmt.Sprintf("UID #%d shouldn't exist", newUserID)) expect(t, isCacheLengthZero(ucache), fmt.Sprintf("User cache length should be 0, not %d", cacheLength(ucache))) expectIntToBeX(t, common.Users.GlobalCount(), 1, "The number of users should be one, not %d") var awaitingActivation = 5 // TODO: Write tests for the registration validators uid, err := common.Users.Create("Sam", "ReallyBadPassword", "sam@localhost.loc", awaitingActivation, false) expectNilErr(t, err) expect(t, uid == newUserID, fmt.Sprintf("The UID of the new user should be %d not %d", newUserID, uid)) expect(t, common.Users.Exists(newUserID), fmt.Sprintf("UID #%d should exist", newUserID)) user, err = common.Users.Get(newUserID) recordMustExist(t, err, "Couldn't find UID #%d", newUserID) expectUser(user, newUserID, "Sam", 5, false, false, false, false) if ucache != nil { expectIntToBeX(t, ucache.Length(), 1, "User cache length should be 1, not %d") user, err = ucache.Get(newUserID) recordMustExist(t, err, "Couldn't find UID #%d in the cache", newUserID) expect(t, user.ID == newUserID, fmt.Sprintf("user.ID does not match the requested UID. Got '%d' instead.", user.ID)) } err = user.Activate() expectNilErr(t, err) expectIntToBeX(t, user.Group, 5, "Sam should still be in group 5 in this copy") // ? - What if we change the caching mechanism so it isn't hard purged and reloaded? We'll deal with that when we come to it, but for now, this is a sign of a cache bug if ucache != nil { expectIntToBeX(t, ucache.Length(), 0, "User cache length should be 0, not %d") _, err = ucache.Get(newUserID) recordMustNotExist(t, err, "UID #%d shouldn't be in the cache", newUserID) } user, err = common.Users.Get(newUserID) recordMustExist(t, err, "Couldn't find UID #%d", newUserID) expectUser(user, newUserID, "Sam", common.Config.DefaultGroup, false, false, false, false) // Permanent ban duration, _ := time.ParseDuration("0") // TODO: Attempt a double ban, double activation, and double unban err = user.Ban(duration, 1) expectNilErr(t, err) expect(t, user.Group == common.Config.DefaultGroup, fmt.Sprintf("Sam should be in group %d, not %d", common.Config.DefaultGroup, user.Group)) if ucache != nil { expectIntToBeX(t, ucache.Length(), 0, "User cache length should be 0, not %d") _, err = ucache.Get(2) recordMustNotExist(t, err, "UID #%d shouldn't be in the cache", newUserID) } user, err = common.Users.Get(newUserID) recordMustExist(t, err, "Couldn't find UID #%d", newUserID) expectUser(user, newUserID, "Sam", common.BanGroup, false, false, false, true) // TODO: Do tests against the scheduled updates table and the task system to make sure the ban exists there and gets revoked when it should err = user.Unban() expectNilErr(t, err) expectIntToBeX(t, user.Group, common.BanGroup, "Sam should still be in the ban group in this copy") if ucache != nil { expectIntToBeX(t, ucache.Length(), 0, "User cache length should be 0, not %d") _, err = ucache.Get(newUserID) recordMustNotExist(t, err, "UID #%d shouldn't be in the cache", newUserID) } user, err = common.Users.Get(newUserID) recordMustExist(t, err, "Couldn't find UID #%d", newUserID) expectUser(user, newUserID, "Sam", common.Config.DefaultGroup, false, false, false, false) var reportsForumID = 1 // TODO: Use the constant in common? var generalForumID = 2 dummyResponseRecorder := httptest.NewRecorder() bytesBuffer := bytes.NewBuffer([]byte("")) dummyRequest1 := httptest.NewRequest("", "/forum/"+strconv.Itoa(reportsForumID), bytesBuffer) dummyRequest2 := httptest.NewRequest("", "/forum/"+strconv.Itoa(generalForumID), bytesBuffer) var user2 *common.User var changeGroupTest = func(oldGroup int, newGroup int) { err = user.ChangeGroup(newGroup) expectNilErr(t, err) // ! I don't think ChangeGroup should be changing the value of user... Investigate this. expect(t, oldGroup == user.Group, "Someone's mutated this pointer elsewhere") user, err = common.Users.Get(newUserID) recordMustExist(t, err, "Couldn't find UID #%d", newUserID) user2 = common.BlankUser() *user2 = *user } var changeGroupTest2 = func(rank string, firstShouldBe bool, secondShouldBe bool) { _, ferr := common.ForumUserCheck(dummyResponseRecorder, dummyRequest1, user, reportsForumID) expect(t, ferr == nil, "There shouldn't be any errors in forumUserCheck") expect(t, user.Perms.ViewTopic == firstShouldBe, rank+" should be able to access the reports forum") _, ferr = common.ForumUserCheck(dummyResponseRecorder, dummyRequest2, user2, generalForumID) expect(t, ferr == nil, "There shouldn't be any errors in forumUserCheck") expect(t, user2.Perms.ViewTopic == secondShouldBe, "Sam should be able to access the general forum") } changeGroupTest(common.Config.DefaultGroup, 1) expectUser(user, newUserID, "Sam", 1, false, true, true, false) changeGroupTest2("Admins", true, true) changeGroupTest(1, 2) expectUser(user, newUserID, "Sam", 2, false, false, true, false) changeGroupTest2("Mods", true, true) changeGroupTest(2, 3) expectUser(user, newUserID, "Sam", 3, false, false, false, false) changeGroupTest2("Members", false, true) expect(t, user.Perms.ViewTopic != user2.Perms.ViewTopic, "user.Perms.ViewTopic and user2.Perms.ViewTopic should never match") changeGroupTest(3, 4) expectUser(user, newUserID, "Sam", 4, false, false, false, true) changeGroupTest2("Members", false, true) changeGroupTest(4, 5) expectUser(user, newUserID, "Sam", 5, false, false, false, false) changeGroupTest2("Members", false, true) changeGroupTest(5, 6) expectUser(user, newUserID, "Sam", 6, false, false, false, false) changeGroupTest2("Members", false, true) err = user.ChangeGroup(common.Config.DefaultGroup) expectNilErr(t, err) expect(t, user.Group == 6, "Someone's mutated this pointer elsewhere") err = user.Delete() expectNilErr(t, err) expect(t, !common.Users.Exists(newUserID), fmt.Sprintf("UID #%d should no longer exist", newUserID)) if ucache != nil { expectIntToBeX(t, ucache.Length(), 0, "User cache length should be 0, not %d") _, err = ucache.Get(newUserID) recordMustNotExist(t, err, "UID #%d shouldn't be in the cache", newUserID) } _, err = common.Users.Get(newUserID) recordMustNotExist(t, err, "UID #%d shouldn't exist", newUserID) // And a unicode test, even though I doubt it'll fail uid, err = common.Users.Create("γ΅γ ", "πππ", "sam@localhost.loc", awaitingActivation, false) expectNilErr(t, err) expect(t, uid == newUserID+1, fmt.Sprintf("The UID of the new user should be %d", newUserID+1)) expect(t, common.Users.Exists(newUserID+1), fmt.Sprintf("UID #%d should exist", newUserID+1)) user, err = common.Users.Get(newUserID + 1) recordMustExist(t, err, "Couldn't find UID #%d", newUserID+1) expectUser(user, newUserID+1, "γ΅γ ", 5, false, false, false, false) err = user.Delete() expectNilErr(t, err) expect(t, !common.Users.Exists(newUserID+1), fmt.Sprintf("UID #%d should no longer exist", newUserID+1)) // MySQL utf8mb4 username test uid, err = common.Users.Create("πππ", "πππ", "sam@localhost.loc", awaitingActivation, false) expectNilErr(t, err) expect(t, uid == newUserID+2, fmt.Sprintf("The UID of the new user should be %d", newUserID+2)) expect(t, common.Users.Exists(newUserID+2), fmt.Sprintf("UID #%d should exist", newUserID+2)) user, err = common.Users.Get(newUserID + 2) recordMustExist(t, err, "Couldn't find UID #%d", newUserID+1) expectUser(user, newUserID+2, "πππ", 5, false, false, false, false) err = user.Delete() expectNilErr(t, err) expect(t, !common.Users.Exists(newUserID+2), fmt.Sprintf("UID #%d should no longer exist", newUserID+2)) // TODO: Add unicode login tests somewhere? Probably with the rest of the auth tests // TODO: Add tests for the Cache* methods } // TODO: Add an error message to this? func expectNilErr(t *testing.T, item error) { if item != nil { debug.PrintStack() t.Fatal(item) } } func expectIntToBeX(t *testing.T, item int, expect int, errmsg string) { if item != expect { debug.PrintStack() t.Fatalf(errmsg, item) } } func expect(t *testing.T, item bool, errmsg string) { if !item { debug.PrintStack() t.Fatal(errmsg) } } func TestPermsMiddleware(t *testing.T) { if !gloinited { err := gloinit() if err != nil { t.Fatal(err) } } if !common.PluginsInited { common.InitPlugins() } dummyResponseRecorder := httptest.NewRecorder() bytesBuffer := bytes.NewBuffer([]byte("")) dummyRequest := httptest.NewRequest("", "/forum/1", bytesBuffer) user := common.BlankUser() ferr := common.SuperModOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr != nil, "Blank users shouldn't be supermods") user.IsSuperMod = false ferr = common.SuperModOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr != nil, "Non-supermods shouldn't be allowed through supermod gates") user.IsSuperMod = true ferr = common.SuperModOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr == nil, "Supermods should be allowed through supermod gates") // TODO: Loop over the Control Panel routes and make sure only supermods can get in user = common.BlankUser() ferr = common.MemberOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr != nil, "Blank users shouldn't be considered loggedin") user.Loggedin = false ferr = common.MemberOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr != nil, "Guests shouldn't be able to access member areas") user.Loggedin = true ferr = common.MemberOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr == nil, "Logged in users should be able to access member areas") // TODO: Loop over the /user/ routes and make sure only members can access the ones other than /user/username // TODO: Write tests for AdminOnly() user = common.BlankUser() ferr = common.SuperAdminOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr != nil, "Blank users shouldn't be considered super admins") user.IsSuperAdmin = false ferr = common.SuperAdminOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr != nil, "Non-super admins shouldn't be allowed through the super admin gate") user.IsSuperAdmin = true ferr = common.SuperAdminOnly(dummyResponseRecorder, dummyRequest, *user) expect(t, ferr == nil, "Super admins should be allowed through super admin gates") // TODO: Make sure only super admins can access the backups route //dummyResponseRecorder = httptest.NewRecorder() //bytesBuffer = bytes.NewBuffer([]byte("")) //dummyRequest = httptest.NewRequest("", "/panel/backups/", bytesBuffer) } func TestTopicStore(t *testing.T) { if !gloinited { err := gloinit() if err != nil { t.Fatal(err) } } if !common.PluginsInited { common.InitPlugins() } var err error tcache := common.NewMemoryTopicCache(common.Config.TopicCacheCapacity) common.Topics, err = common.NewDefaultTopicStore(tcache) expectNilErr(t, err) topicStoreTest(t) common.Topics, err = common.NewDefaultTopicStore(nil) expectNilErr(t, err) topicStoreTest(t) } func topicStoreTest(t *testing.T) { var topic *common.Topic var err error _, err = common.Topics.Get(-1) recordMustNotExist(t, err, "TID #-1 shouldn't exist") _, err = common.Topics.Get(0) recordMustNotExist(t, err, "TID #0 shouldn't exist") topic, err = common.Topics.Get(1) recordMustExist(t, err, "Couldn't find TID #1") if topic.ID != 1 { t.Errorf("topic.ID does not match the requested TID. Got '%d' instead.", topic.ID) } // TODO: Add BulkGetMap() to the TopicStore ok := common.Topics.Exists(-1) expect(t, !ok, "TID #-1 shouldn't exist") ok = common.Topics.Exists(0) expect(t, !ok, "TID #0 shouldn't exist") ok = common.Topics.Exists(1) expect(t, ok, "TID #1 should exist") count := common.Topics.GlobalCount() if count <= 0 { t.Error("The number of topics should be bigger than zero") t.Error("count", count) } // TODO: Test topic creation and retrieving that created topic plus reload and inspecting the cache } func TestForumStore(t *testing.T) { if !gloinited { gloinit() } if !common.PluginsInited { common.InitPlugins() } _, err := common.Forums.Get(-1) recordMustNotExist(t, err, "FID #-1 shouldn't exist") _, err = common.Forums.Get(0) recordMustNotExist(t, err, "FID #0 shouldn't exist") forum, err := common.Forums.Get(1) recordMustExist(t, err, "Couldn't find FID #1") if forum.ID != 1 { t.Errorf("forum.ID doesn't not match the requested FID. Got '%d' instead.'", forum.ID) } // TODO: Check the preset and forum permissions expect(t, forum.Name == "Reports", fmt.Sprintf("FID #0 is named '%s' and not 'Reports'", forum.Name)) expect(t, !forum.Active, fmt.Sprintf("The reports forum shouldn't be active")) var expectDesc = "All the reports go here" expect(t, forum.Desc == expectDesc, fmt.Sprintf("The forum description should be '%s' not '%s'", expectDesc, forum.Desc)) forum, err = common.Forums.Get(2) recordMustExist(t, err, "Couldn't find FID #1") expect(t, forum.ID == 2, fmt.Sprintf("The FID should be 2 not %d", forum.ID)) expect(t, forum.Name == "General", fmt.Sprintf("The name of the forum should be 'General' not '%s'", forum.Name)) expect(t, forum.Active, fmt.Sprintf("The general forum should be active")) expectDesc = "A place for general discussions which don't fit elsewhere" expect(t, forum.Desc == expectDesc, fmt.Sprintf("The forum description should be '%s' not '%s'", expectDesc, forum.Desc)) ok := common.Forums.Exists(-1) expect(t, !ok, "FID #-1 shouldn't exist") ok = common.Forums.Exists(0) expect(t, !ok, "FID #0 shouldn't exist") ok = common.Forums.Exists(1) expect(t, ok, "FID #1 should exist") ok = common.Forums.Exists(2) expect(t, ok, "FID #2 should exist") ok = common.Forums.Exists(3) expect(t, !ok, "FID #3 shouldn't exist") fid, err := common.Forums.Create("Test Forum", "", true, "all") expectNilErr(t, err) expect(t, fid == 3, "The first forum we create should have an ID of 3") ok = common.Forums.Exists(3) expect(t, ok, "FID #2 should exist") forum, err = common.Forums.Get(3) recordMustExist(t, err, "Couldn't find FID #3") expect(t, forum.ID == 3, fmt.Sprintf("The FID should be 3 not %d", forum.ID)) expect(t, forum.Name == "Test Forum", fmt.Sprintf("The name of the forum should be 'Test Forum' not '%s'", forum.Name)) expect(t, forum.Active, fmt.Sprintf("The test forum should be active")) expect(t, forum.Desc == "", fmt.Sprintf("The forum description should be blank not '%s'", forum.Desc)) // TODO: More forum creation tests // TODO: Test forum deletion // TODO: Test forum update } // TODO: Implement this func TestForumPermsStore(t *testing.T) { if !gloinited { gloinit() } if !common.PluginsInited { common.InitPlugins() } } // TODO: Test the group permissions func TestGroupStore(t *testing.T) { if !gloinited { gloinit() } if !common.PluginsInited { common.InitPlugins() } _, err := common.Groups.Get(-1) recordMustNotExist(t, err, "GID #-1 shouldn't exist") // TODO: Refactor the group store to remove GID #0 group, err := common.Groups.Get(0) recordMustExist(t, err, "Couldn't find GID #0") expect(t, group.ID == 0, fmt.Sprintf("group.ID doesn't not match the requested GID. Got '%d' instead.", group.ID)) expect(t, group.Name == "Unknown", fmt.Sprintf("GID #0 is named '%s' and not 'Unknown'", group.Name)) group, err = common.Groups.Get(1) recordMustExist(t, err, "Couldn't find GID #1") expect(t, group.ID == 1, fmt.Sprintf("group.ID doesn't not match the requested GID. Got '%d' instead.'", group.ID)) ok := common.Groups.Exists(-1) expect(t, !ok, "GID #-1 shouldn't exist") // 0 aka Unknown, for system posts and other oddities ok = common.Groups.Exists(0) expect(t, ok, "GID #0 should exist") ok = common.Groups.Exists(1) expect(t, ok, "GID #1 should exist") var isAdmin = true var isMod = true var isBanned = false gid, err := common.Groups.Create("Testing", "Test", isAdmin, isMod, isBanned) expectNilErr(t, err) expect(t, common.Groups.Exists(gid), "The group we just made doesn't exist") group, err = common.Groups.Get(gid) expectNilErr(t, err) expect(t, group.ID == gid, "The group ID should match the requested ID") expect(t, group.IsAdmin, "This should be an admin group") expect(t, group.IsMod, "This should be a mod group") expect(t, !group.IsBanned, "This shouldn't be a ban group") isAdmin = false isMod = true isBanned = true gid, err = common.Groups.Create("Testing 2", "Test", isAdmin, isMod, isBanned) expectNilErr(t, err) expect(t, common.Groups.Exists(gid), "The group we just made doesn't exist") group, err = common.Groups.Get(gid) expectNilErr(t, err) expect(t, group.ID == gid, "The group ID should match the requested ID") expect(t, !group.IsAdmin, "This should not be an admin group") expect(t, group.IsMod, "This should be a mod group") expect(t, !group.IsBanned, "This shouldn't be a ban group") // TODO: Make sure this pointer doesn't change once we refactor the group store to stop updating the pointer err = group.ChangeRank(false, false, true) expectNilErr(t, err) group, err = common.Groups.Get(gid) expectNilErr(t, err) expect(t, group.ID == gid, "The group ID should match the requested ID") expect(t, !group.IsAdmin, "This shouldn't be an admin group") expect(t, !group.IsMod, "This shouldn't be a mod group") expect(t, group.IsBanned, "This should be a ban group") err = group.ChangeRank(true, true, true) expectNilErr(t, err) group, err = common.Groups.Get(gid) expectNilErr(t, err) expect(t, group.ID == gid, "The group ID should match the requested ID") expect(t, group.IsAdmin, "This should be an admin group") expect(t, group.IsMod, "This should be a mod group") expect(t, !group.IsBanned, "This shouldn't be a ban group") err = group.ChangeRank(false, true, true) expectNilErr(t, err) group, err = common.Groups.Get(gid) expectNilErr(t, err) expect(t, group.ID == gid, "The group ID should match the requested ID") expect(t, !group.IsAdmin, "This shouldn't be an admin group") expect(t, group.IsMod, "This should be a mod group") expect(t, !group.IsBanned, "This shouldn't be a ban group") // Make sure the data is static common.Groups.Reload(gid) group, err = common.Groups.Get(gid) expectNilErr(t, err) expect(t, group.ID == gid, "The group ID should match the requested ID") expect(t, !group.IsAdmin, "This shouldn't be an admin group") expect(t, group.IsMod, "This should be a mod group") expect(t, !group.IsBanned, "This shouldn't be a ban group") // TODO: Test group deletion // TODO: Test group reload // TODO: Test group cache set } func TestReplyStore(t *testing.T) { if !gloinited { gloinit() } if !common.PluginsInited { common.InitPlugins() } _, err := common.Rstore.Get(-1) recordMustNotExist(t, err, "RID #-1 shouldn't exist") _, err = common.Rstore.Get(0) recordMustNotExist(t, err, "RID #0 shouldn't exist") reply, err := common.Rstore.Get(1) expectNilErr(t, err) expect(t, reply.ID == 1, fmt.Sprintf("RID #1 has the wrong ID. It should be 1 not %d", reply.ID)) expect(t, reply.ParentID == 1, fmt.Sprintf("The parent topic of RID #1 should be 1 not %d", reply.ParentID)) expect(t, reply.CreatedBy == 1, fmt.Sprintf("The creator of RID #1 should be 1 not %d", reply.CreatedBy)) expect(t, reply.Content == "A reply!", fmt.Sprintf("The contents of RID #1 should be 'A reply!' not %s", reply.Content)) expect(t, reply.IPAddress == "::1", fmt.Sprintf("The IPAddress of RID#1 should be '::1' not %s", reply.IPAddress)) _, err = common.Rstore.Get(2) recordMustNotExist(t, err, "RID #2 shouldn't exist") // TODO: Test Create and Get //Create(tid int, content string, ipaddress string, fid int, uid int) (id int, err error) topic, err := common.Topics.Get(1) expectNilErr(t, err) rid, err := common.Rstore.Create(topic, "Fofofo", "::1", 1) expectNilErr(t, err) expect(t, rid == 2, fmt.Sprintf("The next reply ID should be 2 not %d", rid)) reply, err = common.Rstore.Get(2) expectNilErr(t, err) expect(t, reply.ID == 2, fmt.Sprintf("RID #2 has the wrong ID. It should be 2 not %d", reply.ID)) expect(t, reply.ParentID == 1, fmt.Sprintf("The parent topic of RID #2 should be 1 not %d", reply.ParentID)) expect(t, reply.CreatedBy == 1, fmt.Sprintf("The creator of RID #2 should be 1 not %d", reply.CreatedBy)) expect(t, reply.Content == "Fofofo", fmt.Sprintf("The contents of RID #2 should be 'Fofofo' not %s", reply.Content)) expect(t, reply.IPAddress == "::1", fmt.Sprintf("The IPAddress of RID #2 should be '::1' not %s", reply.IPAddress)) } func TestProfileReplyStore(t *testing.T) { if !gloinited { gloinit() } if !common.PluginsInited { common.InitPlugins() } _, err := common.Prstore.Get(-1) recordMustNotExist(t, err, "PRID #-1 shouldn't exist") _, err = common.Prstore.Get(0) recordMustNotExist(t, err, "PRID #0 shouldn't exist") _, err = common.Prstore.Get(1) recordMustNotExist(t, err, "PRID #1 shouldn't exist") // ? - Commented this one out as strong constraints like this put an unreasonable load on the database, we only want errors if a delete which should succeed fails //profileReply := common.BlankProfileReply(1) //err = profileReply.Delete() //expect(t,err != nil,"You shouldn't be able to delete profile replies which don't exist") var profileID = 1 prid, err := common.Prstore.Create(profileID, "Haha", 1, "::1") expect(t, err == nil, "Unable to create a profile reply") expect(t, prid == 1, "The first profile reply should have an ID of 1") profileReply, err := common.Prstore.Get(1) expect(t, err == nil, "PRID #1 should exist") expect(t, profileReply.ID == 1, fmt.Sprintf("The profile reply should have an ID of 1 not %d", profileReply.ID)) expect(t, profileReply.ParentID == 1, fmt.Sprintf("The parent ID of the profile reply should be 1 not %d", profileReply.ParentID)) expect(t, profileReply.Content == "Haha", fmt.Sprintf("The profile reply's contents should be 'Haha' not '%s'", profileReply.Content)) expect(t, profileReply.CreatedBy == 1, fmt.Sprintf("The profile reply's creator should be 1 not %d", profileReply.CreatedBy)) expect(t, profileReply.IPAddress == "::1", fmt.Sprintf("The profile reply's IP Address should be '::1' not '%s'", profileReply.IPAddress)) err = profileReply.Delete() expectNilErr(t, err) _, err = common.Prstore.Get(1) expect(t, err != nil, "PRID #1 shouldn't exist after being deleted") // TODO: Test profileReply.SetBody() and profileReply.Creator() } func TestPluginManager(t *testing.T) { if !gloinited { gloinit() } if !common.PluginsInited { common.InitPlugins() } _, ok := common.Plugins["fairy-dust"] expect(t, !ok, "Plugin fairy-dust shouldn't exist") plugin, ok := common.Plugins["bbcode"] expect(t, ok, "Plugin bbcode should exist") expect(t, !plugin.Installable, "Plugin bbcode shouldn't be installable") expect(t, !plugin.Installed, "Plugin bbcode shouldn't be 'installed'") expect(t, !plugin.Active, "Plugin bbcode shouldn't be active") active, err := plugin.BypassActive() expectNilErr(t, err) expect(t, !active, "Plugin bbcode shouldn't be active in the database either") hasPlugin, err := plugin.InDatabase() expectNilErr(t, err) expect(t, !hasPlugin, "Plugin bbcode shouldn't exist in the database") // TODO: Add some test cases for SetActive and SetInstalled before calling AddToDatabase expectNilErr(t, plugin.AddToDatabase(true, false)) expect(t, !plugin.Installable, "Plugin bbcode shouldn't be installable") expect(t, !plugin.Installed, "Plugin bbcode shouldn't be 'installed'") expect(t, plugin.Active, "Plugin bbcode should be active") active, err = plugin.BypassActive() expectNilErr(t, err) expect(t, active, "Plugin bbcode should be active in the database too") hasPlugin, err = plugin.InDatabase() expectNilErr(t, err) expect(t, hasPlugin, "Plugin bbcode should exist in the database") expect(t, plugin.Init != nil, "Plugin bbcode should have an init function") expectNilErr(t, plugin.Init()) expectNilErr(t, plugin.SetActive(true)) expect(t, !plugin.Installable, "Plugin bbcode shouldn't be installable") expect(t, !plugin.Installed, "Plugin bbcode shouldn't be 'installed'") expect(t, plugin.Active, "Plugin bbcode should still be active") active, err = plugin.BypassActive() expectNilErr(t, err) expect(t, active, "Plugin bbcode should still be active in the database too") hasPlugin, err = plugin.InDatabase() expectNilErr(t, err) expect(t, hasPlugin, "Plugin bbcode should still exist in the database") expectNilErr(t, plugin.SetActive(false)) expect(t, !plugin.Installable, "Plugin bbcode shouldn't be installable") expect(t, !plugin.Installed, "Plugin bbcode shouldn't be 'installed'") expect(t, !plugin.Active, "Plugin bbcode shouldn't be active") active, err = plugin.BypassActive() expectNilErr(t, err) expect(t, !active, "Plugin bbcode shouldn't be active in the database") hasPlugin, err = plugin.InDatabase() expectNilErr(t, err) expect(t, hasPlugin, "Plugin bbcode should still exist in the database") expect(t, plugin.Deactivate != nil, "Plugin bbcode should have an init function") plugin.Deactivate() // Returns nothing // Not installable, should not be mutated expect(t, plugin.SetInstalled(true) == common.ErrPluginNotInstallable, "Plugin was set as installed despite not being installable") expect(t, !plugin.Installable, "Plugin bbcode shouldn't be installable") expect(t, !plugin.Installed, "Plugin bbcode shouldn't be 'installed'") expect(t, !plugin.Active, "Plugin bbcode shouldn't be active") active, err = plugin.BypassActive() expectNilErr(t, err) expect(t, !active, "Plugin bbcode shouldn't be active in the database either") hasPlugin, err = plugin.InDatabase() expectNilErr(t, err) expect(t, hasPlugin, "Plugin bbcode should still exist in the database") expect(t, plugin.SetInstalled(false) == common.ErrPluginNotInstallable, "Plugin was set as not installed despite not being installable") expect(t, !plugin.Installable, "Plugin bbcode shouldn't be installable") expect(t, !plugin.Installed, "Plugin bbcode shouldn't be 'installed'") expect(t, !plugin.Active, "Plugin bbcode shouldn't be active") active, err = plugin.BypassActive() expectNilErr(t, err) expect(t, !active, "Plugin bbcode shouldn't be active in the database either") hasPlugin, err = plugin.InDatabase() expectNilErr(t, err) expect(t, hasPlugin, "Plugin bbcode should still exist in the database") // This isn't really installable, but we want to get a few tests done before getting plugins which are stateful plugin.Installable = true expectNilErr(t, plugin.SetInstalled(true)) expect(t, plugin.Installable, "Plugin bbcode should be installable") expect(t, plugin.Installed, "Plugin bbcode should be 'installed'") expect(t, !plugin.Active, "Plugin bbcode shouldn't be active") active, err = plugin.BypassActive() expectNilErr(t, err) expect(t, !active, "Plugin bbcode shouldn't be active in the database either") hasPlugin, err = plugin.InDatabase() expectNilErr(t, err) expect(t, hasPlugin, "Plugin bbcode should still exist in the database") expectNilErr(t, plugin.SetInstalled(false)) expect(t, plugin.Installable, "Plugin bbcode should be installable") expect(t, !plugin.Installed, "Plugin bbcode shouldn't be 'installed'") expect(t, !plugin.Active, "Plugin bbcode shouldn't be active") active, err = plugin.BypassActive() expectNilErr(t, err) expect(t, !active, "Plugin bbcode shouldn't be active in the database either") hasPlugin, err = plugin.InDatabase() expectNilErr(t, err) expect(t, hasPlugin, "Plugin bbcode should still exist in the database") // Bugs sometimes arise when we try to delete a hook when there are multiple, so test for that // TODO: Do a finer grained test for that case...? A bigger test might catch more odd cases with multiple plugins plugin2, ok := common.Plugins["markdown"] expect(t, ok, "Plugin markdown should exist") expect(t, !plugin2.Installable, "Plugin markdown shouldn't be installable") expect(t, !plugin2.Installed, "Plugin markdown shouldn't be 'installed'") expect(t, !plugin2.Active, "Plugin markdown shouldn't be active") active, err = plugin2.BypassActive() expectNilErr(t, err) expect(t, !active, "Plugin markdown shouldn't be active in the database either") hasPlugin, err = plugin2.InDatabase() expectNilErr(t, err) expect(t, !hasPlugin, "Plugin markdown shouldn't exist in the database") expectNilErr(t, plugin2.AddToDatabase(true, false)) expectNilErr(t, plugin2.Init()) expectNilErr(t, plugin.SetActive(true)) expectNilErr(t, plugin.Init()) plugin2.Deactivate() expectNilErr(t, plugin2.SetActive(false)) plugin.Deactivate() expectNilErr(t, plugin.SetActive(false)) // Hook tests expect(t, common.RunSshook("haha", "ho") == "ho", "Sshook shouldn't have anything bound to it yet") var handle = func(in string) (out string) { return in + "hi" } plugin.AddHook("haha", handle) expect(t, common.RunSshook("haha", "ho") == "hohi", "Sshook didn't give hohi") plugin.RemoveHook("haha", handle) expect(t, common.RunSshook("haha", "ho") == "ho", "Sshook shouldn't have anything bound to it anymore") // TODO: Add tests for more hook types } func TestPhrases(t *testing.T) { expect(t, common.GetGlobalPermPhrase("BanUsers") == "Can ban users", "Not the expected phrase") expect(t, common.GetGlobalPermPhrase("NoSuchPerm") == "{lang.perms[NoSuchPerm]}", "Not the expected phrase") expect(t, common.GetLocalPermPhrase("ViewTopic") == "Can view topics", "Not the expected phrase") expect(t, common.GetLocalPermPhrase("NoSuchPerm") == "{lang.perms[NoSuchPerm]}", "Not the expected phrase") // TODO: Cover the other phrase types, also try switching between languages to see if anything strange happens } func TestWordFilters(t *testing.T) { // TODO: Test the word filters and their store expect(t, common.WordFilters.Length() == 0, "Word filter list should be empty") expect(t, common.WordFilters.EstCount() == 0, "Word filter list should be empty") expect(t, common.WordFilters.GlobalCount() == 0, "Word filter list should be empty") filters, err := common.WordFilters.GetAll() expectNilErr(t, err) // TODO: Slightly confusing that we don't get ErrNoRow here expect(t, len(filters) == 0, "Word filter map should be empty") // TODO: Add a test for ParseMessage relating to word filters err = common.WordFilters.Create("imbecile", "lovely") expectNilErr(t, err) expect(t, common.WordFilters.Length() == 1, "Word filter list should not be empty") expect(t, common.WordFilters.EstCount() == 1, "Word filter list should not be empty") expect(t, common.WordFilters.GlobalCount() == 1, "Word filter list should not be empty") filters, err = common.WordFilters.GetAll() expectNilErr(t, err) expect(t, len(filters) == 1, "Word filter map should not be empty") filter := filters[1] expect(t, filter.ID == 1, "Word filter ID should be 1") expect(t, filter.Find == "imbecile", "Word filter needle should be imbecile") expect(t, filter.Replacement == "lovely", "Word filter replacement should be lovely") // TODO: Add a test for ParseMessage relating to word filters // TODO: Add deletion tests } func TestSlugs(t *testing.T) { var res string var msgList []MEPair common.Config.BuildSlugs = true // Flip this switch, otherwise all the tests will fail msgList = addMEPair(msgList, "Unknown", "unknown") msgList = addMEPair(msgList, "Unknown2", "unknown2") msgList = addMEPair(msgList, "Unknown ", "unknown") msgList = addMEPair(msgList, "Unknown 2", "unknown-2") msgList = addMEPair(msgList, "Unknown 2", "unknown-2") msgList = addMEPair(msgList, "Admin Alice", "admin-alice") msgList = addMEPair(msgList, "Admin_Alice", "adminalice") msgList = addMEPair(msgList, "Admin_Alice-", "adminalice") msgList = addMEPair(msgList, "-Admin_Alice-", "adminalice") msgList = addMEPair(msgList, "-Admin@Alice-", "adminalice") msgList = addMEPair(msgList, "-AdminπAlice-", "adminalice") msgList = addMEPair(msgList, "u", "u") msgList = addMEPair(msgList, "", "untitled") msgList = addMEPair(msgList, " ", "untitled") msgList = addMEPair(msgList, "-", "untitled") msgList = addMEPair(msgList, "--", "untitled") msgList = addMEPair(msgList, "Γ©", "Γ©") msgList = addMEPair(msgList, "-Γ©-", "Γ©") msgList = addMEPair(msgList, "-δ½ ε₯½-", "untitled") msgList = addMEPair(msgList, "-γγ«γ‘γ―-", "untitled") for _, item := range msgList { t.Log("Testing string '" + item.Msg + "'") res = common.NameToSlug(item.Msg) if res != item.Expects { t.Error("Bad output:", "'"+res+"'") t.Error("Expected:", item.Expects) } } } func TestAuth(t *testing.T) { // bcrypt likes doing stupid things, so this test will probably fail realPassword := "Madame Cassandra's Mystic Orb" t.Logf("Set realPassword to '%s'", realPassword) t.Log("Hashing the real password with bcrypt") hashedPassword, _, err := common.BcryptGeneratePassword(realPassword) if err != nil { t.Error(err) } passwordTest(t, realPassword, hashedPassword) // TODO: Peek at the prefix to verify this is a bcrypt hash t.Log("Hashing the real password") hashedPassword2, _, err := common.GeneratePassword(realPassword) if err != nil { t.Error(err) } passwordTest(t, realPassword, hashedPassword2) // TODO: Peek at the prefix to verify this is a bcrypt hash _, err, _ = common.Auth.Authenticate("None", "password") errmsg := "Username None shouldn't exist" if err != nil { errmsg += "\n" + err.Error() } expect(t, err == common.ErrNoUserByName, errmsg) uid, err, _ := common.Auth.Authenticate("Admin", "password") expectNilErr(t, err) expect(t, uid == 1, fmt.Sprintf("Default admin uid should be 1 not %d", uid)) _, err, _ = common.Auth.Authenticate("Sam", "ReallyBadPassword") errmsg = "Username Sam shouldn't exist" if err != nil { errmsg += "\n" + err.Error() } expect(t, err == common.ErrNoUserByName, errmsg) admin, err := common.Users.Get(1) expectNilErr(t, err) // TODO: Move this into the user store tests to provide better coverage? E.g. To see if the installer and the user creator initialise the field differently expect(t, admin.Session == "", "Admin session should be blank") session, err := common.Auth.CreateSession(1) expectNilErr(t, err) expect(t, session != "", "Admin session shouldn't be blank") // TODO: Test the actual length set in the setting in addition to this "too short" test // TODO: We might be able to push up this minimum requirement expect(t, len(session) > 10, "Admin session shouldn't be too short") expect(t, admin.Session != session, "Old session should not match new one") admin, err = common.Users.Get(1) expectNilErr(t, err) expect(t, admin.Session == session, "Sessions should match") // TODO: Create a user with a unicode password and see if we can login as them // TODO: Tests for SessionCheck, GetCookies, and ForceLogout } // TODO: Vary the salts? Keep in mind that some algorithms store the salt in the hash therefore the salt string may be blank func passwordTest(t *testing.T, realPassword string, hashedPassword string) { if len(hashedPassword) < 10 { t.Error("Hash too short") } salt := "" password := realPassword t.Logf("Testing password '%s'", password) t.Logf("Testing salt '%s'", salt) err := common.CheckPassword(hashedPassword, password, salt) if err == common.ErrMismatchedHashAndPassword { t.Error("The two don't match") } else if err == common.ErrPasswordTooLong { t.Error("CheckPassword thinks the password is too long") } else if err != nil { t.Error(err) } password = "hahaha" t.Logf("Testing password '%s'", password) t.Logf("Testing salt '%s'", salt) err = common.CheckPassword(hashedPassword, password, salt) if err == common.ErrPasswordTooLong { t.Error("CheckPassword thinks the password is too long") } else if err == nil { t.Error("The two shouldn't match!") } password = "Madame Cassandra's Mystic" t.Logf("Testing password '%s'", password) t.Logf("Testing salt '%s'", salt) err = common.CheckPassword(hashedPassword, password, salt) expect(t, err != common.ErrPasswordTooLong, "CheckPassword thinks the password is too long") expect(t, err != nil, "The two shouldn't match!") } type METri struct { Name string // Optional, this is here for tests involving invisible characters so we know what's going in Msg string Expects string } func addMETri(msgList []METri, args ...string) []METri { if len(args) < 2 { panic("need 2 or more args") } if len(args) > 2 { return append(msgList, METri{args[0], args[1], args[2]}) } return append(msgList, METri{"", args[0], args[1]}) } type CountTest struct { Name string Msg string Expects int } type CountTestList struct { Items []CountTest } func (tlist *CountTestList) Add(name string, msg string, expects int) { tlist.Items = append(tlist.Items, CountTest{name, msg, expects}) } //WordCount(input string) (count int) func TestWordCount(t *testing.T) { var msgList = &CountTestList{nil} msgList.Add("blank", "", 0) msgList.Add("single-letter", "h", 1) msgList.Add("single-kana", "γ", 1) msgList.Add("single-letter-words", "h h", 2) msgList.Add("two-letter", "h", 1) msgList.Add("two-kana", "γγ―", 1) msgList.Add("two-letter-words", "hh hh", 2) msgList.Add("", "h,h", 2) msgList.Add("", "h,,h", 2) msgList.Add("", "h, h", 2) msgList.Add("", " h, h", 2) msgList.Add("", "h, h ", 2) msgList.Add("", " h, h ", 2) msgList.Add("", "h, h", 2) msgList.Add("", "h\nh", 2) msgList.Add("", "γ,γ", 2) msgList.Add("", "γγγ", 2) msgList.Add("", "γ\nγ", 2) for _, item := range msgList.Items { res := common.WordCount(item.Msg) if res != item.Expects { if item.Name != "" { t.Error("Name: ", item.Name) } t.Error("Testing string '" + item.Msg + "'") t.Error("Bad output:", res) t.Error("Expected:", item.Expects) } } } func TestPreparser(t *testing.T) { var msgList []METri // Note: The open tag is evaluated without knowledge of the close tag for efficiency and simplicity, so the parser autofills the associated close tag when it finds an open tag without a partner msgList = addMETri(msgList, "", "") msgList = addMETri(msgList, " ", "") msgList = addMETri(msgList, " hi", "hi") msgList = addMETri(msgList, "hi ", "hi") msgList = addMETri(msgList, "hi", "hi") msgList = addMETri(msgList, ":grinning:", "π") msgList = addMETri(msgList, "π", "π") msgList = addMETri(msgList, " ", "") msgList = addMETri(msgList, "
", "") msgList = addMETri(msgList, "
", "") msgList = addMETri(msgList, "", "") msgList = addMETri(msgList, "<", "<") msgList = addMETri(msgList, ">", ">") msgList = addMETri(msgList, "