a
/
zlog
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
zlog/ctx_test.go

71 lines
1.6 KiB
Go
Raw Normal View History

change log
2022-03-20 19:19:42 +00:00
package zlog
Add context methods
2017-05-19 19:59:10 +00:00
import (
"context"
"io/ioutil"
"reflect"
"testing"
)
func TestCtx(t *testing.T) {
log := New(ioutil.Discard)
ctx := log.WithContext(context.Background())
Improve context.Context logging
2017-05-20 07:22:37 +00:00
log2 := Ctx(ctx)
Improve hlog handlers performance by switching to pointer logger Update request logger's context thru its pointer in order to avoid multiple copies/allocations.
2017-08-30 05:53:32 +00:00
if !reflect.DeepEqual(log, *log2) {
Improve context.Context logging
2017-05-20 07:22:37 +00:00
t.Error("Ctx did not return the expected logger")
Add context methods
2017-05-19 19:59:10 +00:00
}
Add http.Handler helpers (adapted from xlog)
2017-05-20 08:48:00 +00:00
// update
log = log.Level(InfoLevel)
ctx = log.WithContext(ctx)
log2 = Ctx(ctx)
Improve hlog handlers performance by switching to pointer logger Update request logger's context thru its pointer in order to avoid multiple copies/allocations.
2017-08-30 05:53:32 +00:00
if !reflect.DeepEqual(log, *log2) {
Add http.Handler helpers (adapted from xlog)
2017-05-20 08:48:00 +00:00
t.Error("Ctx did not return the expected logger")
}
Improve context.Context logging
2017-05-20 07:22:37 +00:00
log2 = Ctx(context.Background())
Improve hlog handlers performance by switching to pointer logger Update request logger's context thru its pointer in order to avoid multiple copies/allocations.
2017-08-30 05:53:32 +00:00
if log2 != disabledLogger {
Improve context.Context logging
2017-05-20 07:22:37 +00:00
t.Error("Ctx did not return the expected logger")
Add context methods
2017-05-19 19:59:10 +00:00
}
Allow user configuration of which logger to return from Ctx() (#343) If a user is trying to fetch a logger from their context, they probably want to log something. In order to allow returning a useable logger from Ctx() without breaking backwards compatibilty with the previous behavior, we make it configurable.
2021-08-12 00:18:16 +00:00
DefaultContextLogger = &log
t.Cleanup(func() { DefaultContextLogger = nil })
log2 = Ctx(context.Background())
if log2 != &log {
t.Error("Ctx did not return the expected logger")
}
Add context methods
2017-05-19 19:59:10 +00:00
}
Improve hlog handlers performance by switching to pointer logger Update request logger's context thru its pointer in order to avoid multiple copies/allocations.
2017-08-30 05:53:32 +00:00
func TestCtxDisabled(t *testing.T) {
ctx: store logger in context when missing or different that stored one (#81) Current implementation stores a copy of the logger as a pointer and update its content, which is now unecessary since the introduction of WithContext. The new WithContext now takes the pointer and store it in the context if none is stored already or if the last one stored is a different pointer. This way it is still possible to update the context of a logger stored in the context, but it is also possible to store a copy of the logger in a sub-context. Fix #80
2018-07-03 01:23:53 +00:00
dl := New(ioutil.Discard).Level(Disabled)
ctx := dl.WithContext(context.Background())
Improve hlog handlers performance by switching to pointer logger Update request logger's context thru its pointer in order to avoid multiple copies/allocations.
2017-08-30 05:53:32 +00:00
if ctx != context.Background() {
t.Error("WithContext stored a disabled logger")
}
ctx: store logger in context when missing or different that stored one (#81) Current implementation stores a copy of the logger as a pointer and update its content, which is now unecessary since the introduction of WithContext. The new WithContext now takes the pointer and store it in the context if none is stored already or if the last one stored is a different pointer. This way it is still possible to update the context of a logger stored in the context, but it is also possible to store a copy of the logger in a sub-context. Fix #80
2018-07-03 01:23:53 +00:00
l := New(ioutil.Discard).With().Str("foo", "bar").Logger()
ctx = l.WithContext(ctx)
ctx: Modify WithContext to use a non-pointer receiver (#409)
2022-02-24 00:17:11 +00:00
if !reflect.DeepEqual(Ctx(ctx), &l) {
Improve hlog handlers performance by switching to pointer logger Update request logger's context thru its pointer in order to avoid multiple copies/allocations.
2017-08-30 05:53:32 +00:00
t.Error("WithContext did not store logger")
}
ctx: store logger in context when missing or different that stored one (#81) Current implementation stores a copy of the logger as a pointer and update its content, which is now unecessary since the introduction of WithContext. The new WithContext now takes the pointer and store it in the context if none is stored already or if the last one stored is a different pointer. This way it is still possible to update the context of a logger stored in the context, but it is also possible to store a copy of the logger in a sub-context. Fix #80
2018-07-03 01:23:53 +00:00
l.UpdateContext(func(c Context) Context {
return c.Str("bar", "baz")
})
ctx = l.WithContext(ctx)
ctx: Modify WithContext to use a non-pointer receiver (#409)
2022-02-24 00:17:11 +00:00
if !reflect.DeepEqual(Ctx(ctx), &l) {
ctx: store logger in context when missing or different that stored one (#81) Current implementation stores a copy of the logger as a pointer and update its content, which is now unecessary since the introduction of WithContext. The new WithContext now takes the pointer and store it in the context if none is stored already or if the last one stored is a different pointer. This way it is still possible to update the context of a logger stored in the context, but it is also possible to store a copy of the logger in a sub-context. Fix #80
2018-07-03 01:23:53 +00:00
t.Error("WithContext did not store updated logger")
}
l = l.Level(DebugLevel)
ctx = l.WithContext(ctx)
ctx: Modify WithContext to use a non-pointer receiver (#409)
2022-02-24 00:17:11 +00:00
if !reflect.DeepEqual(Ctx(ctx), &l) {
ctx: store logger in context when missing or different that stored one (#81) Current implementation stores a copy of the logger as a pointer and update its content, which is now unecessary since the introduction of WithContext. The new WithContext now takes the pointer and store it in the context if none is stored already or if the last one stored is a different pointer. This way it is still possible to update the context of a logger stored in the context, but it is also possible to store a copy of the logger in a sub-context. Fix #80
2018-07-03 01:23:53 +00:00
t.Error("WithContext did not store copied logger")
}
ctx = dl.WithContext(ctx)
ctx: Modify WithContext to use a non-pointer receiver (#409)
2022-02-24 00:17:11 +00:00
if !reflect.DeepEqual(Ctx(ctx), &dl) {
Consistent casing, redundancy, and spelling/grammar (#391) * fix casing * remove redundant type conversions * remove unnecessary append x = append(y) is equivalent to x = y * fix grammar and spelling * rename file to enforce consistent casing with other READMEs in this repo
2021-12-21 12:07:54 +00:00
t.Error("WithContext did not override logger with a disabled logger")
Improve hlog handlers performance by switching to pointer logger Update request logger's context thru its pointer in order to avoid multiple copies/allocations.
2017-08-30 05:53:32 +00:00
}
}