a/gosora
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed a bug with users slipping past the topic list cache.

Browse Source
This commit is contained in:
Azareal 2018-08-27 19:06:00 +10:00
parent 6408dcb1ac
commit f9dedc9691
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/topic_list.go
View File

@ -129,6 +129,9 @@ func (tList *DefaultTopicList) RebuildPermTree() error {
} }
func (tList *DefaultTopicList) GetListByGroup(group *Group, page int) (topicList []*TopicsRow, forumList []Forum, paginator Paginator, err error) { func (tList *DefaultTopicList) GetListByGroup(group *Group, page int) (topicList []*TopicsRow, forumList []Forum, paginator Paginator, err error) {
if page == 0 {
page = 1
}
// TODO: Cache the first three pages not just the first along with all the topics on this beaten track // TODO: Cache the first three pages not just the first along with all the topics on this beaten track
if page == 1 { if page == 1 {
var holder *TopicListHolder var holder *TopicListHolder
@ -148,6 +151,7 @@ func (tList *DefaultTopicList) GetListByGroup(group *Group, page int) (topicList
} }
// TODO: Make CanSee a method on *Group with a canSee field? Have a CanSee method on *User to cover the case of superadmins? // TODO: Make CanSee a method on *Group with a canSee field? Have a CanSee method on *User to cover the case of superadmins?
//log.Printf("deoptimising for %d on page %d\n", group.ID, page)
return tList.GetListByCanSee(group.CanSee, page) return tList.GetListByCanSee(group.CanSee, page)
} }