a/gosora
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added a missing bounds check in peekMatch.

Browse Source
This commit is contained in:
Azareal 2018-07-18 16:36:16 +10:00
parent e5ef86b59c
commit 75a6ceca84
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
common/parser.go
View File

@ -171,6 +171,7 @@ type TagToAction struct {
PartialMode bool PartialMode bool
} }
// TODO: Write a test for this
func tryStepForward(i int, step int, runes []rune) (int, bool) { func tryStepForward(i int, step int, runes []rune) (int, bool) {
i += step i += step
if i < len(runes) { if i < len(runes) {
@ -387,6 +388,9 @@ func peekMatch(cur int, phrase string, runes []rune) bool {
return false return false
} }
for i, char := range phrase { for i, char := range phrase {
if cur+i+1 >= len(runes) {
return false
}
if runes[cur+i+1] != char { if runes[cur+i+1] != char {
return false return false
} }
@ -396,6 +400,7 @@ func peekMatch(cur int, phrase string, runes []rune) bool {
// TODO: Write a test for this // TODO: Write a test for this
// TODO: We need a lot more hooks here. E.g. To add custom media types and handlers. // TODO: We need a lot more hooks here. E.g. To add custom media types and handlers.
// TODO: Use templates to reduce the amount of boilerplate?
func ParseMessage(msg string, sectionID int, sectionType string /*, user User*/) string { func ParseMessage(msg string, sectionID int, sectionType string /*, user User*/) string {
msg = strings.Replace(msg, ":)", "😀", -1) msg = strings.Replace(msg, ":)", "😀", -1)
msg = strings.Replace(msg, ":(", "😞", -1) msg = strings.Replace(msg, ":(", "😞", -1)