Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
package main
2017-10-16 07:32:58 +00:00
import (
2017-10-21 00:27:47 +00:00
"bytes"
2019-10-06 01:49:31 +00:00
"database/sql"
2017-10-16 07:32:58 +00:00
"fmt"
2017-10-21 00:27:47 +00:00
"net/http/httptest"
2017-10-16 07:32:58 +00:00
"runtime/debug"
2018-06-06 00:21:22 +00:00
"strconv"
2017-10-16 07:32:58 +00:00
"testing"
"time"
2017-11-11 04:06:16 +00:00
2019-04-19 08:20:10 +00:00
c "github.com/Azareal/Gosora/common"
2018-11-01 06:43:56 +00:00
"github.com/Azareal/Gosora/common/phrases"
2017-10-16 07:32:58 +00:00
)
2018-11-01 06:43:56 +00:00
func miscinit ( t * testing . T ) {
2019-10-06 00:34:09 +00:00
if err := gloinit ( ) ; err != nil {
2018-11-01 06:43:56 +00:00
t . Fatal ( err )
}
}
2017-10-21 00:27:47 +00:00
func recordMustExist ( t * testing . T , err error , errmsg string , args ... interface { } ) {
2017-10-16 07:32:58 +00:00
if err == ErrNoRows {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-21 00:27:47 +00:00
t . Errorf ( errmsg , args ... )
2017-10-16 07:32:58 +00:00
} else if err != nil {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-16 07:32:58 +00:00
t . Fatal ( err )
}
}
2017-10-21 00:27:47 +00:00
func recordMustNotExist ( t * testing . T , err error , errmsg string , args ... interface { } ) {
2017-10-16 07:32:58 +00:00
if err == nil {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-21 00:27:47 +00:00
t . Errorf ( errmsg , args ... )
2017-10-16 07:32:58 +00:00
} else if err != ErrNoRows {
2018-05-28 06:27:12 +00:00
debug . PrintStack ( )
2017-10-16 07:32:58 +00:00
t . Fatal ( err )
}
}
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
func TestUserStore ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-09-03 04:50:31 +00:00
}
2017-11-02 13:35:19 +00:00
var err error
2019-04-19 08:20:10 +00:00
ucache := c . NewMemoryUserCache ( c . Config . UserCacheCapacity )
c . Users , err = c . NewDefaultUserStore ( ucache )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2017-11-23 05:37:08 +00:00
ucache . Flush ( )
2017-10-16 07:32:58 +00:00
userStoreTest ( t , 2 )
2019-04-19 08:20:10 +00:00
c . Users , err = c . NewDefaultUserStore ( nil )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2018-10-04 04:59:14 +00:00
userStoreTest ( t , 5 )
2017-09-15 22:20:01 +00:00
}
2017-10-16 07:32:58 +00:00
func userStoreTest ( t * testing . T , newUserID int ) {
2019-04-19 08:20:10 +00:00
ucache := c . Users . GetCache ( )
2017-10-21 00:27:47 +00:00
// Go doesn't have short-circuiting, so this'll allow us to do one liner tests
2019-04-19 08:20:10 +00:00
isCacheLengthZero := func ( ucache c . UserCache ) bool {
2017-11-23 05:37:08 +00:00
if ucache == nil {
return true
}
return ucache . Length ( ) == 0
}
2019-04-19 08:20:10 +00:00
cacheLength := func ( ucache c . UserCache ) int {
2017-11-23 05:37:08 +00:00
if ucache == nil {
return 0
}
return ucache . Length ( )
2017-09-18 17:03:52 +00:00
}
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "The initial ucache length should be zero, not %d" , cacheLength ( ucache ) ) )
2017-09-03 04:50:31 +00:00
2019-04-19 08:20:10 +00:00
_ , err := c . Users . Get ( - 1 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #-1 shouldn't exist" )
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "We found %d items in the user cache and it's supposed to be empty" , cacheLength ( ucache ) ) )
2017-09-18 17:03:52 +00:00
2019-04-19 08:20:10 +00:00
_ , err = c . Users . Get ( 0 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #0 shouldn't exist" )
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "We found %d items in the user cache and it's supposed to be empty" , cacheLength ( ucache ) ) )
2017-09-03 04:50:31 +00:00
2019-04-19 08:20:10 +00:00
user , err := c . Users . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find UID #1" )
2017-09-03 04:50:31 +00:00
2019-10-06 00:34:09 +00:00
expectW := func ( cond bool , expec bool , prefix string , suffix string ) {
2018-10-04 02:58:01 +00:00
midfix := "should not be"
if expec {
midfix = "should be"
}
expect ( t , cond , prefix + " " + midfix + " " + suffix )
}
2018-12-27 05:42:41 +00:00
// TODO: Add email checks too? Do them separately?
2019-10-06 00:34:09 +00:00
expectUser := func ( u * c . User , uid int , name string , group int , super bool , admin bool , mod bool , banned bool ) {
expect ( t , u . ID == uid , fmt . Sprintf ( "u.ID should be %d. Got '%d' instead." , uid , u . ID ) )
expect ( t , u . Name == name , fmt . Sprintf ( "u.Name should be '%s', not '%s'" , name , u . Name ) )
expectW ( u . Group == group , true , u . Name , "in group" + strconv . Itoa ( group ) )
expectW ( u . IsSuperAdmin == super , super , u . Name , "a super admin" )
expectW ( u . IsAdmin == admin , admin , u . Name , "an admin" )
expectW ( u . IsSuperMod == mod , mod , u . Name , "a super mod" )
expectW ( u . IsMod == mod , mod , u . Name , "a mod" )
expectW ( u . IsBanned == banned , banned , u . Name , "banned" )
2018-10-04 02:58:01 +00:00
}
expectUser ( user , 1 , "Admin" , 1 , true , true , true , false )
2017-10-16 07:32:58 +00:00
2019-04-19 08:20:10 +00:00
_ , err = c . Users . Get ( newUserID )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , fmt . Sprintf ( "UID #%d shouldn't exist" , newUserID ) )
2017-09-03 04:50:31 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 1 , "User cache length should be 1, not %d" )
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( - 1 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #-1 shouldn't exist, even in the cache" )
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( 0 )
2017-10-16 07:32:58 +00:00
recordMustNotExist ( t , err , "UID #0 shouldn't exist, even in the cache" )
2017-11-23 05:37:08 +00:00
user , err = ucache . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find UID #1 in the cache" )
2017-09-18 17:03:52 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
expect ( t , user . Name == "Admin" , fmt . Sprintf ( "user.Name should be 'Admin', not '%s'" , user . Name ) )
2017-10-16 07:32:58 +00:00
2017-11-23 05:37:08 +00:00
_ , err = ucache . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't exist, even in the cache" , newUserID )
2017-09-18 17:03:52 +00:00
ucache . Flush ( )
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 0 , "User cache length should be 0, not %d" )
2017-09-18 17:03:52 +00:00
}
2017-09-10 16:57:22 +00:00
// TODO: Lock onto the specific error type. Is this even possible without sacrificing the detailed information in the error message?
2019-04-19 08:20:10 +00:00
var userList map [ int ] * c . User
userList , _ = c . Users . BulkGetMap ( [ ] int { - 1 } )
2017-11-23 05:37:08 +00:00
expect ( t , len ( userList ) == 0 , fmt . Sprintf ( "The userList length should be 0, not %d" , len ( userList ) ) )
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "User cache length should be 0, not %d" , cacheLength ( ucache ) ) )
2017-09-18 17:03:52 +00:00
2019-04-19 08:20:10 +00:00
userList , _ = c . Users . BulkGetMap ( [ ] int { 0 } )
2017-11-23 05:37:08 +00:00
expect ( t , len ( userList ) == 0 , fmt . Sprintf ( "The userList length should be 0, not %d" , len ( userList ) ) )
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "User cache length should be 0, not %d" , cacheLength ( ucache ) ) )
2017-09-18 17:03:52 +00:00
2019-04-19 08:20:10 +00:00
userList , _ = c . Users . BulkGetMap ( [ ] int { 1 } )
2018-06-06 06:13:55 +00:00
expect ( t , len ( userList ) == 1 , fmt . Sprintf ( "Returned map should have one result (UID #1), not %d" , len ( userList ) ) )
2017-09-15 22:20:01 +00:00
user , ok := userList [ 1 ]
if ! ok {
t . Error ( "We couldn't find UID #1 in the returned map" )
t . Error ( "userList" , userList )
2017-12-25 06:12:19 +00:00
return
2017-09-15 22:20:01 +00:00
}
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 1 , "User cache length should be 1, not %d" )
2017-11-23 05:37:08 +00:00
user , err = ucache . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find UID #1 in the cache" )
2017-09-18 17:03:52 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
2017-09-18 17:03:52 +00:00
ucache . Flush ( )
}
2019-04-19 08:20:10 +00:00
expect ( t , ! c . Users . Exists ( - 1 ) , "UID #-1 shouldn't exist" )
expect ( t , ! c . Users . Exists ( 0 ) , "UID #0 shouldn't exist" )
expect ( t , c . Users . Exists ( 1 ) , "UID #1 should exist" )
expect ( t , ! c . Users . Exists ( newUserID ) , fmt . Sprintf ( "UID #%d shouldn't exist" , newUserID ) )
2017-10-16 07:32:58 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , isCacheLengthZero ( ucache ) , fmt . Sprintf ( "User cache length should be 0, not %d" , cacheLength ( ucache ) ) )
2019-06-01 12:31:48 +00:00
expectIntToBeX ( t , c . Users . Count ( ) , 1 , "The number of users should be one, not %d" )
2017-09-03 04:50:31 +00:00
2019-10-06 00:34:09 +00:00
awaitingActivation := 5
2018-10-04 02:58:01 +00:00
// TODO: Write tests for the registration validators
2019-04-19 08:20:10 +00:00
uid , err := c . Users . Create ( "Sam" , "ReallyBadPassword" , "sam@localhost.loc" , awaitingActivation , false )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2018-10-04 02:58:01 +00:00
expect ( t , uid == newUserID , fmt . Sprintf ( "The UID of the new user should be %d not %d" , newUserID , uid ) )
2019-04-19 08:20:10 +00:00
expect ( t , c . Users . Exists ( newUserID ) , fmt . Sprintf ( "UID #%d should exist" , newUserID ) )
2017-09-03 04:50:31 +00:00
2019-04-19 08:20:10 +00:00
user , err = c . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
2018-10-04 02:58:01 +00:00
expectUser ( user , newUserID , "Sam" , 5 , false , false , false , false )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
if ucache != nil {
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , ucache . Length ( ) , 1 , "User cache length should be 1, not %d" )
2017-11-23 05:37:08 +00:00
user , err = ucache . Get ( newUserID )
2019-06-16 06:30:58 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d in the cache" , newUserID )
expect ( t , user . ID == newUserID , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
}
2019-10-06 01:49:31 +00:00
userList , _ = c . Users . BulkGetMap ( [ ] int { 1 , uid } )
2019-06-16 06:30:58 +00:00
expect ( t , len ( userList ) == 2 , fmt . Sprintf ( "Returned map should have two results, not %d" , len ( userList ) ) )
if ucache != nil {
expectIntToBeX ( t , ucache . Length ( ) , 2 , "User cache length should be 2, not %d" )
user , err = ucache . Get ( 1 )
recordMustExist ( t , err , "Couldn't find UID #%d in the cache" , 1 )
expect ( t , user . ID == 1 , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
user , err = ucache . Get ( newUserID )
recordMustExist ( t , err , "Couldn't find UID #%d in the cache" , newUserID )
expect ( t , user . ID == newUserID , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
ucache . Flush ( )
}
user , err = c . Users . Get ( newUserID )
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
expectUser ( user , newUserID , "Sam" , 5 , false , false , false , false )
if ucache != nil {
expectIntToBeX ( t , ucache . Length ( ) , 1 , "User cache length should be 1, not %d" )
user , err = ucache . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d in the cache" , newUserID )
expect ( t , user . ID == newUserID , fmt . Sprintf ( "user.ID does not match the requested UID. Got '%d' instead." , user . ID ) )
2017-09-18 17:03:52 +00:00
}
2017-10-16 07:32:58 +00:00
err = user . Activate ( )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2017-10-16 07:32:58 +00:00
expectIntToBeX ( t , user . Group , 5 , "Sam should still be in group 5 in this copy" )
// ? - What if we change the caching mechanism so it isn't hard purged and reloaded? We'll deal with that when we come to it, but for now, this is a sign of a cache bug
2019-10-06 00:34:09 +00:00
afterUserFlush := func ( uid int ) {
2018-10-05 07:41:28 +00:00
if ucache != nil {
expectIntToBeX ( t , ucache . Length ( ) , 0 , "User cache length should be 0, not %d" )
_ , err = ucache . Get ( uid )
recordMustNotExist ( t , err , "UID #%d shouldn't be in the cache" , uid )
}
2017-10-16 07:32:58 +00:00
}
2018-10-05 07:41:28 +00:00
afterUserFlush ( newUserID )
2017-10-16 07:32:58 +00:00
2019-04-19 08:20:10 +00:00
user , err = c . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
2019-04-19 08:20:10 +00:00
expectUser ( user , newUserID , "Sam" , c . Config . DefaultGroup , false , false , false , false )
2017-10-16 07:32:58 +00:00
// Permanent ban
duration , _ := time . ParseDuration ( "0" )
// TODO: Attempt a double ban, double activation, and double unban
err = user . Ban ( duration , 1 )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
expect ( t , user . Group == c . Config . DefaultGroup , fmt . Sprintf ( "Sam should be in group %d, not %d" , c . Config . DefaultGroup , user . Group ) )
2018-10-05 07:41:28 +00:00
afterUserFlush ( newUserID )
2017-10-16 07:32:58 +00:00
2019-04-19 08:20:10 +00:00
user , err = c . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
2019-04-19 08:20:10 +00:00
expectUser ( user , newUserID , "Sam" , c . BanGroup , false , false , false , true )
2017-10-16 07:32:58 +00:00
// TODO: Do tests against the scheduled updates table and the task system to make sure the ban exists there and gets revoked when it should
err = user . Unban ( )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
expectIntToBeX ( t , user . Group , c . BanGroup , "Sam should still be in the ban group in this copy" )
2018-10-05 07:41:28 +00:00
afterUserFlush ( newUserID )
2017-10-16 07:32:58 +00:00
2019-04-19 08:20:10 +00:00
user , err = c . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
2019-04-19 08:20:10 +00:00
expectUser ( user , newUserID , "Sam" , c . Config . DefaultGroup , false , false , false , false )
2017-10-21 00:27:47 +00:00
2019-10-06 00:34:09 +00:00
reportsForumID := 1 // TODO: Use the constant in common?
generalForumID := 2
2017-10-21 00:27:47 +00:00
dummyResponseRecorder := httptest . NewRecorder ( )
bytesBuffer := bytes . NewBuffer ( [ ] byte ( "" ) )
2018-06-06 00:21:22 +00:00
dummyRequest1 := httptest . NewRequest ( "" , "/forum/" + strconv . Itoa ( reportsForumID ) , bytesBuffer )
dummyRequest2 := httptest . NewRequest ( "" , "/forum/" + strconv . Itoa ( generalForumID ) , bytesBuffer )
2019-04-19 08:20:10 +00:00
var user2 * c . User
2018-10-04 04:59:14 +00:00
2019-10-06 00:34:09 +00:00
changeGroupTest := func ( oldGroup int , newGroup int ) {
2018-10-04 04:59:14 +00:00
err = user . ChangeGroup ( newGroup )
expectNilErr ( t , err )
// ! I don't think ChangeGroup should be changing the value of user... Investigate this.
expect ( t , oldGroup == user . Group , "Someone's mutated this pointer elsewhere" )
2019-04-19 08:20:10 +00:00
user , err = c . Users . Get ( newUserID )
2018-10-04 04:59:14 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID )
2019-04-19 08:20:10 +00:00
user2 = c . BlankUser ( )
2018-10-04 04:59:14 +00:00
* user2 = * user
}
2017-10-21 00:27:47 +00:00
2019-10-06 00:34:09 +00:00
changeGroupTest2 := func ( rank string , firstShouldBe bool , secondShouldBe bool ) {
2019-04-19 08:20:10 +00:00
head , err := c . UserCheck ( dummyResponseRecorder , dummyRequest1 , user )
2018-11-12 09:23:36 +00:00
if err != nil {
t . Fatal ( err )
}
2019-04-19 08:20:10 +00:00
head2 , err := c . UserCheck ( dummyResponseRecorder , dummyRequest2 , user2 )
2018-11-12 09:23:36 +00:00
if err != nil {
t . Fatal ( err )
}
2019-04-19 08:20:10 +00:00
ferr := c . ForumUserCheck ( head , dummyResponseRecorder , dummyRequest1 , user , reportsForumID )
2018-10-04 04:59:14 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
expect ( t , user . Perms . ViewTopic == firstShouldBe , rank + " should be able to access the reports forum" )
2019-04-19 08:20:10 +00:00
ferr = c . ForumUserCheck ( head2 , dummyResponseRecorder , dummyRequest2 , user2 , generalForumID )
2018-10-04 04:59:14 +00:00
expect ( t , ferr == nil , "There shouldn't be any errors in forumUserCheck" )
expect ( t , user2 . Perms . ViewTopic == secondShouldBe , "Sam should be able to access the general forum" )
}
2017-10-21 00:27:47 +00:00
2019-04-19 08:20:10 +00:00
changeGroupTest ( c . Config . DefaultGroup , 1 )
2018-10-04 02:58:01 +00:00
expectUser ( user , newUserID , "Sam" , 1 , false , true , true , false )
2018-10-04 04:59:14 +00:00
changeGroupTest2 ( "Admins" , true , true )
2017-10-21 00:27:47 +00:00
2018-10-04 04:59:14 +00:00
changeGroupTest ( 1 , 2 )
2018-10-04 02:58:01 +00:00
expectUser ( user , newUserID , "Sam" , 2 , false , false , true , false )
2018-10-04 04:59:14 +00:00
changeGroupTest2 ( "Mods" , true , true )
2017-10-21 00:27:47 +00:00
2018-10-04 04:59:14 +00:00
changeGroupTest ( 2 , 3 )
2018-10-04 02:58:01 +00:00
expectUser ( user , newUserID , "Sam" , 3 , false , false , false , false )
2018-10-04 04:59:14 +00:00
changeGroupTest2 ( "Members" , false , true )
2017-10-21 00:27:47 +00:00
expect ( t , user . Perms . ViewTopic != user2 . Perms . ViewTopic , "user.Perms.ViewTopic and user2.Perms.ViewTopic should never match" )
2018-10-04 04:59:14 +00:00
changeGroupTest ( 3 , 4 )
2018-10-04 02:58:01 +00:00
expectUser ( user , newUserID , "Sam" , 4 , false , false , false , true )
2018-10-04 04:59:14 +00:00
changeGroupTest2 ( "Members" , false , true )
2017-10-21 00:27:47 +00:00
2018-10-04 04:59:14 +00:00
changeGroupTest ( 4 , 5 )
2018-10-04 02:58:01 +00:00
expectUser ( user , newUserID , "Sam" , 5 , false , false , false , false )
2018-10-04 04:59:14 +00:00
changeGroupTest2 ( "Members" , false , true )
2017-10-21 00:27:47 +00:00
2018-10-04 04:59:14 +00:00
changeGroupTest ( 5 , 6 )
2018-10-04 02:58:01 +00:00
expectUser ( user , newUserID , "Sam" , 6 , false , false , false , false )
2018-10-04 04:59:14 +00:00
changeGroupTest2 ( "Members" , false , true )
2017-10-21 00:27:47 +00:00
2019-04-19 08:20:10 +00:00
err = user . ChangeGroup ( c . Config . DefaultGroup )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , user . Group == 6 , "Someone's mutated this pointer elsewhere" )
2017-10-16 07:32:58 +00:00
err = user . Delete ( )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
expect ( t , ! c . Users . Exists ( newUserID ) , fmt . Sprintf ( "UID #%d should no longer exist" , newUserID ) )
2018-10-05 07:41:28 +00:00
afterUserFlush ( newUserID )
2017-10-16 07:32:58 +00:00
2019-04-19 08:20:10 +00:00
_ , err = c . Users . Get ( newUserID )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "UID #%d shouldn't exist" , newUserID )
2017-11-05 01:04:57 +00:00
2018-10-04 02:58:01 +00:00
// And a unicode test, even though I doubt it'll fail
2019-04-19 08:20:10 +00:00
uid , err = c . Users . Create ( "サム" , "😀😀😀" , "sam@localhost.loc" , awaitingActivation , false )
2018-10-04 02:58:01 +00:00
expectNilErr ( t , err )
expect ( t , uid == newUserID + 1 , fmt . Sprintf ( "The UID of the new user should be %d" , newUserID + 1 ) )
2019-04-19 08:20:10 +00:00
expect ( t , c . Users . Exists ( newUserID + 1 ) , fmt . Sprintf ( "UID #%d should exist" , newUserID + 1 ) )
2018-10-04 02:58:01 +00:00
2019-04-19 08:20:10 +00:00
user , err = c . Users . Get ( newUserID + 1 )
2018-10-04 02:58:01 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID + 1 )
expectUser ( user , newUserID + 1 , "サム" , 5 , false , false , false , false )
err = user . Delete ( )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
expect ( t , ! c . Users . Exists ( newUserID + 1 ) , fmt . Sprintf ( "UID #%d should no longer exist" , newUserID + 1 ) )
2018-10-04 02:58:01 +00:00
2018-10-04 04:59:14 +00:00
// MySQL utf8mb4 username test
2019-04-19 08:20:10 +00:00
uid , err = c . Users . Create ( "😀😀😀" , "😀😀😀" , "sam@localhost.loc" , awaitingActivation , false )
2018-10-04 04:59:14 +00:00
expectNilErr ( t , err )
expect ( t , uid == newUserID + 2 , fmt . Sprintf ( "The UID of the new user should be %d" , newUserID + 2 ) )
2019-04-19 08:20:10 +00:00
expect ( t , c . Users . Exists ( newUserID + 2 ) , fmt . Sprintf ( "UID #%d should exist" , newUserID + 2 ) )
2018-10-04 04:59:14 +00:00
2019-04-19 08:20:10 +00:00
user , err = c . Users . Get ( newUserID + 2 )
2018-10-04 04:59:14 +00:00
recordMustExist ( t , err , "Couldn't find UID #%d" , newUserID + 1 )
expectUser ( user , newUserID + 2 , "😀😀😀" , 5 , false , false , false , false )
err = user . Delete ( )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
expect ( t , ! c . Users . Exists ( newUserID + 2 ) , fmt . Sprintf ( "UID #%d should no longer exist" , newUserID + 2 ) )
2018-10-04 04:59:14 +00:00
2018-10-04 02:58:01 +00:00
// TODO: Add unicode login tests somewhere? Probably with the rest of the auth tests
2017-11-05 01:04:57 +00:00
// TODO: Add tests for the Cache* methods
2017-10-21 00:27:47 +00:00
}
// TODO: Add an error message to this?
func expectNilErr ( t * testing . T , item error ) {
if item != nil {
debug . PrintStack ( )
t . Fatal ( item )
}
2017-10-16 07:32:58 +00:00
}
func expectIntToBeX ( t * testing . T , item int , expect int , errmsg string ) {
if item != expect {
debug . PrintStack ( )
t . Fatalf ( errmsg , item )
}
}
func expect ( t * testing . T , item bool , errmsg string ) {
if ! item {
debug . PrintStack ( )
2017-10-21 00:27:47 +00:00
t . Fatal ( errmsg )
2017-09-15 22:20:01 +00:00
}
}
2017-11-05 01:04:57 +00:00
func TestPermsMiddleware ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-11-05 01:04:57 +00:00
}
dummyResponseRecorder := httptest . NewRecorder ( )
bytesBuffer := bytes . NewBuffer ( [ ] byte ( "" ) )
dummyRequest := httptest . NewRequest ( "" , "/forum/1" , bytesBuffer )
2019-04-19 08:20:10 +00:00
user := c . BlankUser ( )
2017-11-05 01:04:57 +00:00
2019-04-19 08:20:10 +00:00
ferr := c . SuperModOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 01:04:57 +00:00
expect ( t , ferr != nil , "Blank users shouldn't be supermods" )
user . IsSuperMod = false
2019-04-19 08:20:10 +00:00
ferr = c . SuperModOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 01:04:57 +00:00
expect ( t , ferr != nil , "Non-supermods shouldn't be allowed through supermod gates" )
user . IsSuperMod = true
2019-04-19 08:20:10 +00:00
ferr = c . SuperModOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 01:04:57 +00:00
expect ( t , ferr == nil , "Supermods should be allowed through supermod gates" )
// TODO: Loop over the Control Panel routes and make sure only supermods can get in
2017-11-05 09:55:34 +00:00
2019-04-19 08:20:10 +00:00
user = c . BlankUser ( )
2017-11-05 09:55:34 +00:00
2019-04-19 08:20:10 +00:00
ferr = c . MemberOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 09:55:34 +00:00
expect ( t , ferr != nil , "Blank users shouldn't be considered loggedin" )
user . Loggedin = false
2019-04-19 08:20:10 +00:00
ferr = c . MemberOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 09:55:34 +00:00
expect ( t , ferr != nil , "Guests shouldn't be able to access member areas" )
user . Loggedin = true
2019-04-19 08:20:10 +00:00
ferr = c . MemberOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-11-05 09:55:34 +00:00
expect ( t , ferr == nil , "Logged in users should be able to access member areas" )
// TODO: Loop over the /user/ routes and make sure only members can access the ones other than /user/username
2017-12-19 03:53:13 +00:00
// TODO: Write tests for AdminOnly()
2019-04-19 08:20:10 +00:00
user = c . BlankUser ( )
2017-12-19 03:53:13 +00:00
2019-04-19 08:20:10 +00:00
ferr = c . SuperAdminOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-12-19 03:53:13 +00:00
expect ( t , ferr != nil , "Blank users shouldn't be considered super admins" )
user . IsSuperAdmin = false
2019-04-19 08:20:10 +00:00
ferr = c . SuperAdminOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-12-19 03:53:13 +00:00
expect ( t , ferr != nil , "Non-super admins shouldn't be allowed through the super admin gate" )
user . IsSuperAdmin = true
2019-04-19 08:20:10 +00:00
ferr = c . SuperAdminOnly ( dummyResponseRecorder , dummyRequest , * user )
2017-12-19 03:53:13 +00:00
expect ( t , ferr == nil , "Super admins should be allowed through super admin gates" )
// TODO: Make sure only super admins can access the backups route
//dummyResponseRecorder = httptest.NewRecorder()
//bytesBuffer = bytes.NewBuffer([]byte(""))
//dummyRequest = httptest.NewRequest("", "/panel/backups/", bytesBuffer)
2017-11-05 01:04:57 +00:00
}
2017-09-15 22:20:01 +00:00
func TestTopicStore ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-09-15 22:20:01 +00:00
}
2017-11-02 13:35:19 +00:00
var err error
2019-04-19 08:20:10 +00:00
tcache := c . NewMemoryTopicCache ( c . Config . TopicCacheCapacity )
c . Topics , err = c . NewDefaultTopicStore ( tcache )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2018-10-07 10:46:49 +00:00
topicStoreTest ( t , 2 )
2019-04-19 08:20:10 +00:00
c . Topics , err = c . NewDefaultTopicStore ( nil )
2017-11-02 13:35:19 +00:00
expectNilErr ( t , err )
2018-10-07 10:46:49 +00:00
topicStoreTest ( t , 3 )
2017-09-15 22:20:01 +00:00
}
2018-10-07 10:46:49 +00:00
func topicStoreTest ( t * testing . T , newID int ) {
2019-04-19 08:20:10 +00:00
var topic * c . Topic
2017-09-15 22:20:01 +00:00
var err error
2019-04-19 08:20:10 +00:00
_ , err = c . Topics . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "TID #-1 shouldn't exist" )
2019-04-19 08:20:10 +00:00
_ , err = c . Topics . Get ( 0 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "TID #0 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2019-04-19 08:20:10 +00:00
topic , err = c . Topics . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find TID #1" )
2018-10-05 07:41:28 +00:00
expect ( t , topic . ID == 1 , fmt . Sprintf ( "topic.ID does not match the requested TID. Got '%d' instead." , topic . ID ) )
2017-09-03 04:50:31 +00:00
2017-09-15 22:20:01 +00:00
// TODO: Add BulkGetMap() to the TopicStore
2019-04-19 08:20:10 +00:00
ok := c . Topics . Exists ( - 1 )
2017-11-23 05:37:08 +00:00
expect ( t , ! ok , "TID #-1 shouldn't exist" )
2019-04-19 08:20:10 +00:00
ok = c . Topics . Exists ( 0 )
2017-11-23 05:37:08 +00:00
expect ( t , ! ok , "TID #0 shouldn't exist" )
2019-04-19 08:20:10 +00:00
ok = c . Topics . Exists ( 1 )
2017-11-23 05:37:08 +00:00
expect ( t , ok , "TID #1 should exist" )
2017-09-03 04:50:31 +00:00
2019-06-01 12:31:48 +00:00
count := c . Topics . Count ( )
2018-10-07 10:46:49 +00:00
expect ( t , count == 1 , fmt . Sprintf ( "Global count for topics should be 1, not %d" , count ) )
//Create(fid int, topicName string, content string, uid int, ipaddress string) (tid int, err error)
2019-04-19 08:20:10 +00:00
tid , err := c . Topics . Create ( 2 , "Test Topic" , "Topic Content" , 1 , "::1" )
2018-10-07 10:46:49 +00:00
expectNilErr ( t , err )
expect ( t , tid == newID , fmt . Sprintf ( "TID for the new topic should be %d, not %d" , newID , tid ) )
2019-04-19 08:20:10 +00:00
expect ( t , c . Topics . Exists ( newID ) , fmt . Sprintf ( "TID #%d should exist" , newID ) )
2018-10-07 10:46:49 +00:00
2019-06-01 12:31:48 +00:00
count = c . Topics . Count ( )
2018-10-07 10:46:49 +00:00
expect ( t , count == 2 , fmt . Sprintf ( "Global count for topics should be 2, not %d" , count ) )
2019-10-06 00:34:09 +00:00
iFrag := func ( cond bool ) string {
2018-10-07 10:46:49 +00:00
if ! cond {
return "n't"
}
return ""
}
2019-08-31 22:34:43 +00:00
testTopic := func ( tid int , title string , content string , createdBy int , ip string , parentID int , isClosed bool , sticky bool ) {
2019-04-19 08:20:10 +00:00
topic , err = c . Topics . Get ( tid )
2018-10-07 10:46:49 +00:00
recordMustExist ( t , err , fmt . Sprintf ( "Couldn't find TID #%d" , tid ) )
expect ( t , topic . ID == tid , fmt . Sprintf ( "topic.ID does not match the requested TID. Got '%d' instead." , topic . ID ) )
expect ( t , topic . GetID ( ) == tid , fmt . Sprintf ( "topic.ID does not match the requested TID. Got '%d' instead." , topic . GetID ( ) ) )
expect ( t , topic . Title == title , fmt . Sprintf ( "The topic's name should be '%s', not %s" , title , topic . Title ) )
expect ( t , topic . Content == content , fmt . Sprintf ( "The topic's body should be '%s', not %s" , content , topic . Content ) )
expect ( t , topic . CreatedBy == createdBy , fmt . Sprintf ( "The topic's creator should be %d, not %d" , createdBy , topic . CreatedBy ) )
2019-08-31 22:34:43 +00:00
expect ( t , topic . IP == ip , fmt . Sprintf ( "The topic's IP should be '%s', not %s" , ip , topic . IP ) )
2018-10-07 10:46:49 +00:00
expect ( t , topic . ParentID == parentID , fmt . Sprintf ( "The topic's parent forum should be %d, not %d" , parentID , topic . ParentID ) )
expect ( t , topic . IsClosed == isClosed , fmt . Sprintf ( "This topic should%s be locked" , iFrag ( topic . IsClosed ) ) )
expect ( t , topic . Sticky == sticky , fmt . Sprintf ( "This topic should%s be sticky" , iFrag ( topic . Sticky ) ) )
expect ( t , topic . GetTable ( ) == "topics" , fmt . Sprintf ( "The topic's table should be 'topics', not %s" , topic . GetTable ( ) ) )
}
2019-04-19 08:20:10 +00:00
tcache := c . Topics . GetCache ( )
2019-10-06 00:34:09 +00:00
shouldNotBeIn := func ( tid int ) {
2018-10-07 10:46:49 +00:00
if tcache != nil {
_ , err = tcache . Get ( tid )
recordMustNotExist ( t , err , "Topic cache should be empty" )
}
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
}
2018-10-07 10:46:49 +00:00
if tcache != nil {
_ , err = tcache . Get ( newID )
expectNilErr ( t , err )
}
testTopic ( newID , "Test Topic" , "Topic Content" , 1 , "::1" , 2 , false , false )
expectNilErr ( t , topic . Lock ( ) )
shouldNotBeIn ( newID )
testTopic ( newID , "Test Topic" , "Topic Content" , 1 , "::1" , 2 , true , false )
expectNilErr ( t , topic . Unlock ( ) )
shouldNotBeIn ( newID )
testTopic ( newID , "Test Topic" , "Topic Content" , 1 , "::1" , 2 , false , false )
expectNilErr ( t , topic . Stick ( ) )
shouldNotBeIn ( newID )
testTopic ( newID , "Test Topic" , "Topic Content" , 1 , "::1" , 2 , false , true )
expectNilErr ( t , topic . Unstick ( ) )
shouldNotBeIn ( newID )
testTopic ( newID , "Test Topic" , "Topic Content" , 1 , "::1" , 2 , false , false )
expectNilErr ( t , topic . MoveTo ( 1 ) )
shouldNotBeIn ( newID )
testTopic ( newID , "Test Topic" , "Topic Content" , 1 , "::1" , 1 , false , false )
// TODO: Add more tests for more *Topic methods
expectNilErr ( t , topic . Delete ( ) )
shouldNotBeIn ( newID )
2019-04-19 08:20:10 +00:00
_ , err = c . Topics . Get ( newID )
2018-10-07 10:46:49 +00:00
recordMustNotExist ( t , err , fmt . Sprintf ( "TID #%d shouldn't exist" , newID ) )
2019-04-19 08:20:10 +00:00
expect ( t , ! c . Topics . Exists ( newID ) , fmt . Sprintf ( "TID #%d shouldn't exist" , newID ) )
2017-11-06 16:24:45 +00:00
// TODO: Test topic creation and retrieving that created topic plus reload and inspecting the cache
2017-07-12 11:05:18 +00:00
}
func TestForumStore ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-09-03 04:50:31 +00:00
}
2019-05-27 09:00:40 +00:00
// TODO: Test ForumStore.Reload
2017-09-03 04:50:31 +00:00
2019-05-18 12:17:50 +00:00
fcache , ok := c . Forums . ( c . ForumCache )
expect ( t , ok , "Unable to cast ForumStore to ForumCache" )
2019-06-01 12:31:48 +00:00
expect ( t , c . Forums . Count ( ) == 2 , "The forumstore global count should be 2" )
2019-05-18 12:17:50 +00:00
expect ( t , fcache . Length ( ) == 2 , "The forum cache length should be 2" )
2019-05-18 10:31:51 +00:00
2019-04-19 08:20:10 +00:00
_ , err := c . Forums . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "FID #-1 shouldn't exist" )
2019-04-19 08:20:10 +00:00
_ , err = c . Forums . Get ( 0 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "FID #0 shouldn't exist" )
2017-09-03 04:50:31 +00:00
2019-04-19 08:20:10 +00:00
forum , err := c . Forums . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find FID #1" )
2018-10-05 07:41:28 +00:00
expect ( t , forum . ID == 1 , fmt . Sprintf ( "forum.ID doesn't not match the requested FID. Got '%d' instead.'" , forum . ID ) )
2017-11-05 01:04:57 +00:00
// TODO: Check the preset and forum permissions
expect ( t , forum . Name == "Reports" , fmt . Sprintf ( "FID #0 is named '%s' and not 'Reports'" , forum . Name ) )
expect ( t , ! forum . Active , fmt . Sprintf ( "The reports forum shouldn't be active" ) )
2019-10-06 00:34:09 +00:00
expectDesc := "All the reports go here"
2017-11-05 01:04:57 +00:00
expect ( t , forum . Desc == expectDesc , fmt . Sprintf ( "The forum description should be '%s' not '%s'" , expectDesc , forum . Desc ) )
2019-05-18 12:17:50 +00:00
forum , err = c . Forums . BypassGet ( 1 )
recordMustExist ( t , err , "Couldn't find FID #1" )
2017-09-03 04:50:31 +00:00
2019-04-19 08:20:10 +00:00
forum , err = c . Forums . Get ( 2 )
2018-10-05 07:41:28 +00:00
recordMustExist ( t , err , "Couldn't find FID #2" )
2019-05-18 12:17:50 +00:00
forum , err = c . Forums . BypassGet ( 2 )
recordMustExist ( t , err , "Couldn't find FID #2" )
2017-09-10 16:57:22 +00:00
2017-11-05 01:04:57 +00:00
expect ( t , forum . ID == 2 , fmt . Sprintf ( "The FID should be 2 not %d" , forum . ID ) )
expect ( t , forum . Name == "General" , fmt . Sprintf ( "The name of the forum should be 'General' not '%s'" , forum . Name ) )
expect ( t , forum . Active , fmt . Sprintf ( "The general forum should be active" ) )
expectDesc = "A place for general discussions which don't fit elsewhere"
expect ( t , forum . Desc == expectDesc , fmt . Sprintf ( "The forum description should be '%s' not '%s'" , expectDesc , forum . Desc ) )
2017-09-15 22:20:01 +00:00
2019-05-27 09:00:40 +00:00
// Forum reload test, kind of hacky but gets the job done
/ *
2019-10-06 01:49:31 +00:00
CacheGet ( id int ) ( * Forum , error )
CacheSet ( forum * Forum ) error
2019-05-27 09:00:40 +00:00
* /
2019-10-06 01:49:31 +00:00
expect ( t , ok , "ForumCache should be available" )
2019-05-27 09:00:40 +00:00
forum . Name = "nanana"
fcache . CacheSet ( forum )
forum , err = c . Forums . Get ( 2 )
recordMustExist ( t , err , "Couldn't find FID #2" )
expect ( t , forum . Name == "nanana" , fmt . Sprintf ( "The faux name should be nanana not %s" , forum . Name ) )
2019-10-06 01:49:31 +00:00
expectNilErr ( t , c . Forums . Reload ( 2 ) )
2019-05-27 09:00:40 +00:00
forum , err = c . Forums . Get ( 2 )
recordMustExist ( t , err , "Couldn't find FID #2" )
expect ( t , forum . Name == "General" , fmt . Sprintf ( "The proper name should be 2 not %s" , forum . Name ) )
2019-05-18 10:31:51 +00:00
expect ( t , ! c . Forums . Exists ( - 1 ) , "FID #-1 shouldn't exist" )
expect ( t , ! c . Forums . Exists ( 0 ) , "FID #0 shouldn't exist" )
expect ( t , c . Forums . Exists ( 1 ) , "FID #1 should exist" )
expect ( t , c . Forums . Exists ( 2 ) , "FID #2 should exist" )
expect ( t , ! c . Forums . Exists ( 3 ) , "FID #3 shouldn't exist" )
_ , err = c . Forums . Create ( "" , "" , true , "all" )
expect ( t , err != nil , "A forum shouldn't be successfully created, if it has a blank name" )
2017-11-05 01:04:57 +00:00
2019-04-19 08:20:10 +00:00
fid , err := c . Forums . Create ( "Test Forum" , "" , true , "all" )
2017-12-25 06:12:19 +00:00
expectNilErr ( t , err )
expect ( t , fid == 3 , "The first forum we create should have an ID of 3" )
2019-05-18 10:31:51 +00:00
expect ( t , c . Forums . Exists ( 3 ) , "FID #2 should exist" )
2019-06-01 12:31:48 +00:00
expect ( t , c . Forums . Count ( ) == 3 , "The forumstore global count should be 3" )
2019-05-18 12:17:50 +00:00
expect ( t , fcache . Length ( ) == 3 , "The forum cache length should be 3" )
2017-12-25 06:12:19 +00:00
2019-04-19 08:20:10 +00:00
forum , err = c . Forums . Get ( 3 )
2017-12-25 06:12:19 +00:00
recordMustExist ( t , err , "Couldn't find FID #3" )
2019-05-18 12:17:50 +00:00
forum , err = c . Forums . BypassGet ( 3 )
recordMustExist ( t , err , "Couldn't find FID #3" )
2017-12-25 06:12:19 +00:00
2018-06-06 06:13:55 +00:00
expect ( t , forum . ID == 3 , fmt . Sprintf ( "The FID should be 3 not %d" , forum . ID ) )
2017-12-25 06:12:19 +00:00
expect ( t , forum . Name == "Test Forum" , fmt . Sprintf ( "The name of the forum should be 'Test Forum' not '%s'" , forum . Name ) )
expect ( t , forum . Active , fmt . Sprintf ( "The test forum should be active" ) )
2018-04-23 21:08:31 +00:00
expect ( t , forum . Desc == "" , fmt . Sprintf ( "The forum description should be blank not '%s'" , forum . Desc ) )
2017-12-25 06:12:19 +00:00
// TODO: More forum creation tests
2019-05-18 10:31:51 +00:00
expectNilErr ( t , c . Forums . Delete ( 3 ) )
expect ( t , forum . ID == 3 , fmt . Sprintf ( "forum pointer shenanigans" ) )
2019-06-01 12:31:48 +00:00
expect ( t , c . Forums . Count ( ) == 2 , "The forumstore global count should be 2" )
2019-05-18 12:17:50 +00:00
expect ( t , fcache . Length ( ) == 2 , "The forum cache length should be 2" )
2019-05-18 10:31:51 +00:00
expect ( t , ! c . Forums . Exists ( 3 ) , "FID #3 shouldn't exist after being deleted" )
_ , err = c . Forums . Get ( 3 )
recordMustNotExist ( t , err , "FID #3 shouldn't exist after being deleted" )
2019-05-18 12:17:50 +00:00
_ , err = c . Forums . BypassGet ( 3 )
recordMustNotExist ( t , err , "FID #3 shouldn't exist after being deleted" )
expect ( t , c . Forums . Delete ( c . ReportForumID ) != nil , "The reports forum shouldn't be deletable" )
expect ( t , c . Forums . Exists ( c . ReportForumID ) , fmt . Sprintf ( "FID #%d should still exist" , c . ReportForumID ) )
_ , err = c . Forums . Get ( c . ReportForumID )
expect ( t , err == nil , fmt . Sprintf ( "FID #%d should still exist" , c . ReportForumID ) )
_ , err = c . Forums . BypassGet ( c . ReportForumID )
expect ( t , err == nil , fmt . Sprintf ( "FID #%d should still exist" , c . ReportForumID ) )
eforums := map [ int ] bool { 1 : true , 2 : true }
{
forums , err := c . Forums . GetAll ( )
expectNilErr ( t , err )
found := make ( map [ int ] * c . Forum )
for _ , forum := range forums {
_ , ok := eforums [ forum . ID ]
expect ( t , ok , fmt . Sprintf ( "unknown forum #%d in forums" , forum . ID ) )
found [ forum . ID ] = forum
}
for fid , _ := range eforums {
_ , ok := found [ fid ]
expect ( t , ok , fmt . Sprintf ( "unable to find expected forum #%d in forums" , fid ) )
}
}
{
fids , err := c . Forums . GetAllIDs ( )
expectNilErr ( t , err )
found := make ( map [ int ] bool )
for _ , fid := range fids {
_ , ok := eforums [ fid ]
expect ( t , ok , fmt . Sprintf ( "unknown fid #%d in fids" , fid ) )
found [ fid ] = true
}
for fid , _ := range eforums {
_ , ok := found [ fid ]
expect ( t , ok , fmt . Sprintf ( "unable to find expected fid #%d in fids" , fid ) )
}
}
vforums := map [ int ] bool { 2 : true }
{
forums , err := c . Forums . GetAllVisible ( )
expectNilErr ( t , err )
found := make ( map [ int ] * c . Forum )
for _ , forum := range forums {
_ , ok := vforums [ forum . ID ]
expect ( t , ok , fmt . Sprintf ( "unknown forum #%d in forums" , forum . ID ) )
found [ forum . ID ] = forum
}
for fid , _ := range vforums {
_ , ok := found [ fid ]
expect ( t , ok , fmt . Sprintf ( "unable to find expected forum #%d in forums" , fid ) )
}
}
{
fids , err := c . Forums . GetAllVisibleIDs ( )
expectNilErr ( t , err )
found := make ( map [ int ] bool )
for _ , fid := range fids {
_ , ok := vforums [ fid ]
expect ( t , ok , fmt . Sprintf ( "unknown fid #%d in fids" , fid ) )
found [ fid ] = true
}
for fid , _ := range vforums {
_ , ok := found [ fid ]
expect ( t , ok , fmt . Sprintf ( "unable to find expected fid #%d in fids" , fid ) )
}
}
2019-05-18 10:31:51 +00:00
2017-11-05 01:04:57 +00:00
// TODO: Test forum update
2019-05-18 10:31:51 +00:00
// TODO: Other forumstore stuff and forumcache?
2017-11-05 01:04:57 +00:00
}
// TODO: Implement this
func TestForumPermsStore ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-09-15 22:20:01 +00:00
}
2019-06-19 03:16:03 +00:00
2019-10-06 00:34:09 +00:00
f := func ( fid int , gid int , msg string , inv ... bool ) {
2019-10-06 01:49:31 +00:00
fp , err := c . FPStore . Get ( fid , gid )
expectNilErr ( t , err )
2019-10-06 00:34:09 +00:00
vt := fp . ViewTopic
if len ( inv ) > 0 && inv [ 0 ] == true {
vt = ! vt
}
2019-10-06 01:49:31 +00:00
expect ( t , vt , msg )
2019-10-06 00:34:09 +00:00
}
2019-06-19 03:16:03 +00:00
2019-10-06 00:34:09 +00:00
initialState := func ( ) {
2019-10-06 01:49:31 +00:00
f ( 1 , 1 , "admins should be able to see reports" )
f ( 1 , 2 , "mods should be able to see reports" )
f ( 1 , 3 , "members should not be able to see reports" , true )
f ( 1 , 4 , "banned users should not be able to see reports" , true )
f ( 2 , 1 , "admins should be able to see general" )
f ( 2 , 3 , "members should be able to see general" )
f ( 2 , 6 , "guests should be able to see general" )
2019-06-19 03:16:03 +00:00
}
initialState ( )
expectNilErr ( t , c . FPStore . Reload ( 1 ) )
initialState ( )
expectNilErr ( t , c . FPStore . Reload ( 2 ) )
initialState ( )
2017-09-15 22:20:01 +00:00
}
2017-11-05 01:04:57 +00:00
// TODO: Test the group permissions
2019-06-27 23:35:34 +00:00
// TODO: Test group.CanSee for forum presets + group perms
2017-09-15 22:20:01 +00:00
func TestGroupStore ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-09-15 22:20:01 +00:00
}
2019-04-19 08:20:10 +00:00
_ , err := c . Groups . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "GID #-1 shouldn't exist" )
2017-09-15 22:20:01 +00:00
2017-10-16 07:32:58 +00:00
// TODO: Refactor the group store to remove GID #0
2019-04-19 08:20:10 +00:00
group , err := c . Groups . Get ( 0 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find GID #0" )
2017-09-15 22:20:01 +00:00
2017-11-23 05:37:08 +00:00
expect ( t , group . ID == 0 , fmt . Sprintf ( "group.ID doesn't not match the requested GID. Got '%d' instead." , group . ID ) )
2017-10-21 00:27:47 +00:00
expect ( t , group . Name == "Unknown" , fmt . Sprintf ( "GID #0 is named '%s' and not 'Unknown'" , group . Name ) )
2017-09-15 22:20:01 +00:00
2019-04-19 08:20:10 +00:00
group , err = c . Groups . Get ( 1 )
2017-10-16 07:32:58 +00:00
recordMustExist ( t , err , "Couldn't find GID #1" )
2017-11-23 05:37:08 +00:00
expect ( t , group . ID == 1 , fmt . Sprintf ( "group.ID doesn't not match the requested GID. Got '%d' instead.'" , group . ID ) )
2019-10-06 01:49:31 +00:00
expect ( t , len ( group . CanSee ) > 0 , "group.CanSee should not be zero" )
2017-09-15 22:20:01 +00:00
2019-04-19 08:20:10 +00:00
expect ( t , ! c . Groups . Exists ( - 1 ) , "GID #-1 shouldn't exist" )
2017-10-21 00:27:47 +00:00
// 0 aka Unknown, for system posts and other oddities
2019-04-19 08:20:10 +00:00
expect ( t , c . Groups . Exists ( 0 ) , "GID #0 should exist" )
expect ( t , c . Groups . Exists ( 1 ) , "GID #1 should exist" )
2017-10-21 00:27:47 +00:00
2019-10-06 00:34:09 +00:00
isAdmin := true
isMod := true
isBanned := false
2019-04-19 08:20:10 +00:00
gid , err := c . Groups . Create ( "Testing" , "Test" , isAdmin , isMod , isBanned )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
expect ( t , c . Groups . Exists ( gid ) , "The group we just made doesn't exist" )
2017-10-21 00:27:47 +00:00
2019-04-19 08:20:10 +00:00
group , err = c . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , group . IsAdmin , "This should be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
2019-06-27 23:35:34 +00:00
expect ( t , len ( group . CanSee ) == 0 , "group.CanSee should be empty" )
2017-10-21 00:27:47 +00:00
isAdmin = false
isMod = true
isBanned = true
2019-04-19 08:20:10 +00:00
gid , err = c . Groups . Create ( "Testing 2" , "Test" , isAdmin , isMod , isBanned )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
expect ( t , c . Groups . Exists ( gid ) , "The group we just made doesn't exist" )
2017-10-21 00:27:47 +00:00
2019-04-19 08:20:10 +00:00
group , err = c . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This should not be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
// TODO: Make sure this pointer doesn't change once we refactor the group store to stop updating the pointer
err = group . ChangeRank ( false , false , true )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
group , err = c . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This shouldn't be an admin group" )
expect ( t , ! group . IsMod , "This shouldn't be a mod group" )
expect ( t , group . IsBanned , "This should be a ban group" )
err = group . ChangeRank ( true , true , true )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
group , err = c . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , group . IsAdmin , "This should be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
2019-06-18 10:02:45 +00:00
expect ( t , len ( group . CanSee ) == 0 , "len(group.CanSee) should be 0" )
2017-10-21 00:27:47 +00:00
err = group . ChangeRank ( false , true , true )
expectNilErr ( t , err )
2019-06-18 10:02:45 +00:00
forum , err := c . Forums . Get ( 2 )
expectNilErr ( t , err )
forumPerms , err := c . FPStore . GetCopy ( 2 , gid )
if err == sql . ErrNoRows {
forumPerms = * c . BlankForumPerms ( )
} else if err != nil {
expectNilErr ( t , err )
}
forumPerms . ViewTopic = true
err = forum . SetPerms ( & forumPerms , "custom" , gid )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
group , err = c . Groups . Get ( gid )
2017-10-21 00:27:47 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This shouldn't be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
2019-06-19 03:16:03 +00:00
expect ( t , group . CanSee != nil , "group.CanSee must not be nil" )
expect ( t , len ( group . CanSee ) == 1 , "len(group.CanSee) should not be one" )
expect ( t , group . CanSee [ 0 ] == 2 , "group.CanSee[0] should be 2" )
2019-06-18 10:02:45 +00:00
canSee := group . CanSee
2017-10-21 00:27:47 +00:00
2017-11-05 01:04:57 +00:00
// Make sure the data is static
2019-04-19 08:20:10 +00:00
c . Groups . Reload ( gid )
2017-11-05 01:04:57 +00:00
2019-04-19 08:20:10 +00:00
group , err = c . Groups . Get ( gid )
2017-11-05 01:04:57 +00:00
expectNilErr ( t , err )
expect ( t , group . ID == gid , "The group ID should match the requested ID" )
expect ( t , ! group . IsAdmin , "This shouldn't be an admin group" )
expect ( t , group . IsMod , "This should be a mod group" )
expect ( t , ! group . IsBanned , "This shouldn't be a ban group" )
2019-06-18 10:02:45 +00:00
// TODO: Don't enforce a specific order here
canSeeTest := func ( a , b [ ] int ) bool {
if ( a == nil ) != ( b == nil ) {
return false
}
if len ( a ) != len ( b ) {
return false
}
for i := range a {
if a [ i ] != b [ i ] {
return false
}
}
return true
}
2019-10-06 01:49:31 +00:00
expect ( t , canSeeTest ( group . CanSee , canSee ) , "group.CanSee is not being reused" )
2019-06-18 10:02:45 +00:00
2017-10-21 00:27:47 +00:00
// TODO: Test group deletion
2017-11-05 01:04:57 +00:00
// TODO: Test group reload
// TODO: Test group cache set
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
}
2017-10-12 03:24:14 +00:00
func TestReplyStore ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-10-12 03:24:14 +00:00
}
2019-04-19 08:20:10 +00:00
_ , err := c . Rstore . Get ( - 1 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "RID #-1 shouldn't exist" )
2019-04-19 08:20:10 +00:00
_ , err = c . Rstore . Get ( 0 )
2017-10-21 00:27:47 +00:00
recordMustNotExist ( t , err , "RID #0 shouldn't exist" )
2019-08-31 22:34:43 +00:00
replyTest2 := func ( reply * c . Reply , err error , rid int , parentID int , createdBy int , content string , ip string ) {
2018-10-08 04:15:06 +00:00
expectNilErr ( t , err )
expect ( t , reply . ID == rid , fmt . Sprintf ( "RID #%d has the wrong ID. It should be %d not %d" , rid , rid , reply . ID ) )
expect ( t , reply . ParentID == parentID , fmt . Sprintf ( "The parent topic of RID #%d should be %d not %d" , rid , parentID , reply . ParentID ) )
expect ( t , reply . CreatedBy == createdBy , fmt . Sprintf ( "The creator of RID #%d should be %d not %d" , rid , createdBy , reply . CreatedBy ) )
expect ( t , reply . Content == content , fmt . Sprintf ( "The contents of RID #%d should be '%s' not %s" , rid , content , reply . Content ) )
2019-08-31 22:34:43 +00:00
expect ( t , reply . IP == ip , fmt . Sprintf ( "The IP of RID#%d should be '%s' not %s" , rid , ip , reply . IP ) )
2018-10-08 04:15:06 +00:00
}
2019-05-17 08:40:41 +00:00
2019-08-31 22:34:43 +00:00
replyTest := func ( rid int , parentID int , createdBy int , content string , ip string ) {
2019-05-17 08:40:41 +00:00
reply , err := c . Rstore . Get ( rid )
replyTest2 ( reply , err , rid , parentID , createdBy , content , ip )
reply , err = c . Rstore . GetCache ( ) . Get ( rid )
replyTest2 ( reply , err , rid , parentID , createdBy , content , ip )
}
2018-10-08 04:15:06 +00:00
replyTest ( 1 , 1 , 1 , "A reply!" , "::1" )
2017-11-06 16:24:45 +00:00
2019-05-17 08:40:41 +00:00
// ! This is hard to do deterministically as the system may pre-load certain items but let's give it a try:
//_, err = c.Rstore.GetCache().Get(1)
//recordMustNotExist(t, err, "RID #1 shouldn't be in the cache")
2019-04-19 08:20:10 +00:00
_ , err = c . Rstore . Get ( 2 )
2017-11-06 16:24:45 +00:00
recordMustNotExist ( t , err , "RID #2 shouldn't exist" )
2019-04-19 08:20:10 +00:00
topic , err := c . Topics . Get ( 1 )
2017-11-08 07:28:33 +00:00
expectNilErr ( t , err )
2018-10-08 04:15:06 +00:00
expect ( t , topic . PostCount == 1 , fmt . Sprintf ( "TID #1's post count should be one, not %d" , topic . PostCount ) )
2019-05-17 08:40:41 +00:00
_ , err = c . Rstore . GetCache ( ) . Get ( 2 )
recordMustNotExist ( t , err , "RID #2 shouldn't be in the cache" )
2019-04-19 08:20:10 +00:00
rid , err := c . Rstore . Create ( topic , "Fofofo" , "::1" , 1 )
2017-11-06 16:24:45 +00:00
expectNilErr ( t , err )
expect ( t , rid == 2 , fmt . Sprintf ( "The next reply ID should be 2 not %d" , rid ) )
2018-10-08 04:15:06 +00:00
expect ( t , topic . PostCount == 1 , fmt . Sprintf ( "The old TID #1 in memory's post count should be one, not %d" , topic . PostCount ) )
// TODO: Test the reply count on the topic
replyTest ( 2 , 1 , 1 , "Fofofo" , "::1" )
2017-10-12 03:24:14 +00:00
2019-04-19 08:20:10 +00:00
topic , err = c . Topics . Get ( 1 )
2018-10-08 04:15:06 +00:00
expectNilErr ( t , err )
expect ( t , topic . PostCount == 2 , fmt . Sprintf ( "TID #1's post count should be two, not %d" , topic . PostCount ) )
err = topic . CreateActionReply ( "destroy" , "::1" , 1 )
expectNilErr ( t , err )
expect ( t , topic . PostCount == 2 , fmt . Sprintf ( "The old TID #1 in memory's post count should be two, not %d" , topic . PostCount ) )
replyTest ( 3 , 1 , 1 , "" , "::1" )
// TODO: Check the actionType field of the reply, this might not be loaded by TopicStore, maybe we should add it there?
2019-04-19 08:20:10 +00:00
topic , err = c . Topics . Get ( 1 )
2017-11-06 16:24:45 +00:00
expectNilErr ( t , err )
2018-10-08 04:15:06 +00:00
expect ( t , topic . PostCount == 3 , fmt . Sprintf ( "TID #1's post count should be three, not %d" , topic . PostCount ) )
2018-12-31 09:03:49 +00:00
2019-01-21 12:27:59 +00:00
// TODO: Expand upon this
2019-04-19 08:20:10 +00:00
rid , err = c . Rstore . Create ( topic , "hiii" , "::1" , 1 )
2018-12-31 09:03:49 +00:00
expectNilErr ( t , err )
replyTest ( rid , topic . ID , 1 , "hiii" , "::1" )
2019-05-17 08:40:41 +00:00
reply , err := c . Rstore . Get ( rid )
expectNilErr ( t , err )
expectNilErr ( t , reply . SetPost ( "huuu" ) )
expect ( t , reply . Content == "hiii" , fmt . Sprintf ( "topic.Content should be hiii, not %s" , reply . Content ) )
reply , err = c . Rstore . Get ( rid )
expectNilErr ( t , err )
expect ( t , reply . Content == "huuu" , fmt . Sprintf ( "topic.Content should be huuu, not %s" , reply . Content ) )
expectNilErr ( t , reply . Delete ( ) )
// No pointer shenanigans x.x
expect ( t , reply . ID == rid , fmt . Sprintf ( "pointer shenanigans" ) )
_ , err = c . Rstore . GetCache ( ) . Get ( rid )
recordMustNotExist ( t , err , fmt . Sprintf ( "RID #%d shouldn't be in the cache" , rid ) )
_ , err = c . Rstore . Get ( rid )
recordMustNotExist ( t , err , fmt . Sprintf ( "RID #%d shouldn't exist" , rid ) )
// TODO: Write a test for this
//(topic *TopicUser) Replies(offset int, pFrag int, user *User) (rlist []*ReplyUser, ogdesc string, err error)
// TODO: Add tests for *Reply
// TODO: Add tests for ReplyCache
2017-10-12 03:24:14 +00:00
}
func TestProfileReplyStore ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2017-10-12 03:24:14 +00:00
}
2019-04-19 08:20:10 +00:00
_ , err := c . Prstore . Get ( - 1 )
2017-11-06 16:24:45 +00:00
recordMustNotExist ( t , err , "PRID #-1 shouldn't exist" )
2019-04-19 08:20:10 +00:00
_ , err = c . Prstore . Get ( 0 )
2017-11-06 16:24:45 +00:00
recordMustNotExist ( t , err , "PRID #0 shouldn't exist" )
2019-04-19 08:20:10 +00:00
_ , err = c . Prstore . Get ( 1 )
2017-11-07 22:38:15 +00:00
recordMustNotExist ( t , err , "PRID #1 shouldn't exist" )
2017-11-06 16:24:45 +00:00
2018-05-28 06:27:12 +00:00
// ? - Commented this one out as strong constraints like this put an unreasonable load on the database, we only want errors if a delete which should succeed fails
2019-04-19 08:20:10 +00:00
//profileReply := c.BlankProfileReply(1)
2018-05-28 06:27:12 +00:00
//err = profileReply.Delete()
//expect(t,err != nil,"You shouldn't be able to delete profile replies which don't exist")
2019-10-06 00:34:09 +00:00
profileID := 1
2019-04-19 08:20:10 +00:00
prid , err := c . Prstore . Create ( profileID , "Haha" , 1 , "::1" )
2018-10-06 14:02:52 +00:00
expectNilErr ( t , err )
2017-11-06 16:24:45 +00:00
expect ( t , prid == 1 , "The first profile reply should have an ID of 1" )
2019-04-19 08:20:10 +00:00
profileReply , err := c . Prstore . Get ( 1 )
2018-10-06 14:02:52 +00:00
expectNilErr ( t , err )
2017-11-06 16:24:45 +00:00
expect ( t , profileReply . ID == 1 , fmt . Sprintf ( "The profile reply should have an ID of 1 not %d" , profileReply . ID ) )
expect ( t , profileReply . ParentID == 1 , fmt . Sprintf ( "The parent ID of the profile reply should be 1 not %d" , profileReply . ParentID ) )
expect ( t , profileReply . Content == "Haha" , fmt . Sprintf ( "The profile reply's contents should be 'Haha' not '%s'" , profileReply . Content ) )
expect ( t , profileReply . CreatedBy == 1 , fmt . Sprintf ( "The profile reply's creator should be 1 not %d" , profileReply . CreatedBy ) )
2019-08-31 22:34:43 +00:00
expect ( t , profileReply . IP == "::1" , fmt . Sprintf ( "The profile reply's IP should be '::1' not '%s'" , profileReply . IP ) )
2017-11-06 16:24:45 +00:00
2018-05-28 06:27:12 +00:00
err = profileReply . Delete ( )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
_ , err = c . Prstore . Get ( 1 )
2018-05-28 06:27:12 +00:00
expect ( t , err != nil , "PRID #1 shouldn't exist after being deleted" )
2017-11-06 16:24:45 +00:00
2018-05-28 06:27:12 +00:00
// TODO: Test profileReply.SetBody() and profileReply.Creator()
2017-10-12 03:24:14 +00:00
}
2019-06-01 12:31:48 +00:00
func TestActivityStream ( t * testing . T ) {
miscinit ( t )
2019-10-06 01:49:31 +00:00
expect ( t , c . Activity . Count ( ) == 0 , "activity stream count should be 0" )
2019-06-01 12:31:48 +00:00
_ , err := c . Activity . Get ( - 1 )
recordMustNotExist ( t , err , "activity item -1 shouldn't exist" )
_ , err = c . Activity . Get ( 0 )
recordMustNotExist ( t , err , "activity item 0 shouldn't exist" )
_ , err = c . Activity . Get ( 1 )
recordMustNotExist ( t , err , "activity item 1 shouldn't exist" )
a := c . Alert { ActorID : 1 , TargetUserID : 1 , Event : "like" , ElementType : "topic" , ElementID : 1 }
id , err := c . Activity . Add ( a )
2019-10-06 01:49:31 +00:00
expectNilErr ( t , err )
expect ( t , id == 1 , "new activity item id should be 1" )
2019-06-01 12:31:48 +00:00
2019-10-06 01:49:31 +00:00
expect ( t , c . Activity . Count ( ) == 1 , "activity stream count should be 1" )
2019-06-01 12:31:48 +00:00
alert , err := c . Activity . Get ( 1 )
2019-10-06 01:49:31 +00:00
expectNilErr ( t , err )
expect ( t , alert . ActorID == 1 , "alert actorid should be 1" )
expect ( t , alert . TargetUserID == 1 , "alert targetuserid should be 1" )
expect ( t , alert . Event == "like" , "alert event type should be like" )
expect ( t , alert . ElementType == "topic" , "alert element type should be topic" )
expect ( t , alert . ElementID == 1 , "alert element id should be 1" )
2019-06-01 12:31:48 +00:00
}
2018-10-08 02:51:59 +00:00
func TestLogs ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
gTests := func ( store c . LogStore , phrase string ) {
2019-06-01 12:31:48 +00:00
expect ( t , store . Count ( ) == 0 , "There shouldn't be any " + phrase )
2018-10-08 02:51:59 +00:00
logs , err := store . GetOffset ( 0 , 25 )
expectNilErr ( t , err )
expect ( t , len ( logs ) == 0 , "The log slice should be empty" )
}
2019-04-19 08:20:10 +00:00
gTests ( c . ModLogs , "modlogs" )
gTests ( c . AdminLogs , "adminlogs" )
2018-10-08 02:51:59 +00:00
2019-04-19 08:20:10 +00:00
gTests2 := func ( store c . LogStore , phrase string ) {
2018-10-08 02:51:59 +00:00
err := store . Create ( "something" , 0 , "bumblefly" , "::1" , 1 )
expectNilErr ( t , err )
2019-06-01 12:31:48 +00:00
count := store . Count ( )
expect ( t , count == 1 , fmt . Sprintf ( "store.Count should return one, not %d" , count ) )
2018-10-08 02:51:59 +00:00
logs , err := store . GetOffset ( 0 , 25 )
recordMustExist ( t , err , "We should have at-least one " + phrase )
expect ( t , len ( logs ) == 1 , "The length of the log slice should be one" )
log := logs [ 0 ]
expect ( t , log . Action == "something" , "log.Action is not something" )
expect ( t , log . ElementID == 0 , "log.ElementID is not 0" )
expect ( t , log . ElementType == "bumblefly" , "log.ElementType is not bumblefly" )
2019-08-31 22:34:43 +00:00
expect ( t , log . IP == "::1" , "log.IP is not ::1" )
2018-10-08 02:51:59 +00:00
expect ( t , log . ActorID == 1 , "log.ActorID is not 1" )
// TODO: Add a test for log.DoneAt? Maybe throw in some dates and times which are clearly impossible but which may occur due to timezone bugs?
}
2019-04-19 08:20:10 +00:00
gTests2 ( c . ModLogs , "modlog" )
gTests2 ( c . AdminLogs , "adminlog" )
2018-10-08 02:51:59 +00:00
}
// TODO: Add tests for registration logs
2018-07-29 10:54:12 +00:00
func TestPluginManager ( t * testing . T ) {
2018-11-01 06:43:56 +00:00
miscinit ( t )
2019-04-19 08:20:10 +00:00
if ! c . PluginsInited {
c . InitPlugins ( )
2018-07-29 10:54:12 +00:00
}
2019-04-19 08:20:10 +00:00
_ , ok := c . Plugins [ "fairy-dust" ]
2018-07-29 10:54:12 +00:00
expect ( t , ! ok , "Plugin fairy-dust shouldn't exist" )
2019-04-19 08:20:10 +00:00
plugin , ok := c . Plugins [ "bbcode" ]
2018-07-29 10:54:12 +00:00
expect ( t , ok , "Plugin bbcode should exist" )
expect ( t , ! plugin . Installable , "Plugin bbcode shouldn't be installable" )
expect ( t , ! plugin . Installed , "Plugin bbcode shouldn't be 'installed'" )
expect ( t , ! plugin . Active , "Plugin bbcode shouldn't be active" )
active , err := plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , ! active , "Plugin bbcode shouldn't be active in the database either" )
hasPlugin , err := plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , ! hasPlugin , "Plugin bbcode shouldn't exist in the database" )
// TODO: Add some test cases for SetActive and SetInstalled before calling AddToDatabase
expectNilErr ( t , plugin . AddToDatabase ( true , false ) )
expect ( t , ! plugin . Installable , "Plugin bbcode shouldn't be installable" )
expect ( t , ! plugin . Installed , "Plugin bbcode shouldn't be 'installed'" )
expect ( t , plugin . Active , "Plugin bbcode should be active" )
active , err = plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , active , "Plugin bbcode should be active in the database too" )
hasPlugin , err = plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , hasPlugin , "Plugin bbcode should exist in the database" )
expect ( t , plugin . Init != nil , "Plugin bbcode should have an init function" )
2019-02-10 05:52:26 +00:00
expectNilErr ( t , plugin . Init ( plugin ) )
2018-07-29 10:54:12 +00:00
expectNilErr ( t , plugin . SetActive ( true ) )
expect ( t , ! plugin . Installable , "Plugin bbcode shouldn't be installable" )
expect ( t , ! plugin . Installed , "Plugin bbcode shouldn't be 'installed'" )
expect ( t , plugin . Active , "Plugin bbcode should still be active" )
active , err = plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , active , "Plugin bbcode should still be active in the database too" )
hasPlugin , err = plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , hasPlugin , "Plugin bbcode should still exist in the database" )
expectNilErr ( t , plugin . SetActive ( false ) )
expect ( t , ! plugin . Installable , "Plugin bbcode shouldn't be installable" )
expect ( t , ! plugin . Installed , "Plugin bbcode shouldn't be 'installed'" )
expect ( t , ! plugin . Active , "Plugin bbcode shouldn't be active" )
active , err = plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , ! active , "Plugin bbcode shouldn't be active in the database" )
hasPlugin , err = plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , hasPlugin , "Plugin bbcode should still exist in the database" )
expect ( t , plugin . Deactivate != nil , "Plugin bbcode should have an init function" )
2019-02-10 05:52:26 +00:00
plugin . Deactivate ( plugin ) // Returns nothing
2018-07-29 10:54:12 +00:00
// Not installable, should not be mutated
2019-04-19 08:20:10 +00:00
expect ( t , plugin . SetInstalled ( true ) == c . ErrPluginNotInstallable , "Plugin was set as installed despite not being installable" )
2018-07-29 10:54:12 +00:00
expect ( t , ! plugin . Installable , "Plugin bbcode shouldn't be installable" )
expect ( t , ! plugin . Installed , "Plugin bbcode shouldn't be 'installed'" )
expect ( t , ! plugin . Active , "Plugin bbcode shouldn't be active" )
active , err = plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , ! active , "Plugin bbcode shouldn't be active in the database either" )
hasPlugin , err = plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , hasPlugin , "Plugin bbcode should still exist in the database" )
2019-04-19 08:20:10 +00:00
expect ( t , plugin . SetInstalled ( false ) == c . ErrPluginNotInstallable , "Plugin was set as not installed despite not being installable" )
2018-07-29 10:54:12 +00:00
expect ( t , ! plugin . Installable , "Plugin bbcode shouldn't be installable" )
expect ( t , ! plugin . Installed , "Plugin bbcode shouldn't be 'installed'" )
expect ( t , ! plugin . Active , "Plugin bbcode shouldn't be active" )
active , err = plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , ! active , "Plugin bbcode shouldn't be active in the database either" )
hasPlugin , err = plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , hasPlugin , "Plugin bbcode should still exist in the database" )
// This isn't really installable, but we want to get a few tests done before getting plugins which are stateful
plugin . Installable = true
expectNilErr ( t , plugin . SetInstalled ( true ) )
expect ( t , plugin . Installable , "Plugin bbcode should be installable" )
expect ( t , plugin . Installed , "Plugin bbcode should be 'installed'" )
expect ( t , ! plugin . Active , "Plugin bbcode shouldn't be active" )
active , err = plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , ! active , "Plugin bbcode shouldn't be active in the database either" )
hasPlugin , err = plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , hasPlugin , "Plugin bbcode should still exist in the database" )
expectNilErr ( t , plugin . SetInstalled ( false ) )
expect ( t , plugin . Installable , "Plugin bbcode should be installable" )
expect ( t , ! plugin . Installed , "Plugin bbcode shouldn't be 'installed'" )
expect ( t , ! plugin . Active , "Plugin bbcode shouldn't be active" )
active , err = plugin . BypassActive ( )
expectNilErr ( t , err )
expect ( t , ! active , "Plugin bbcode shouldn't be active in the database either" )
hasPlugin , err = plugin . InDatabase ( )
expectNilErr ( t , err )
expect ( t , hasPlugin , "Plugin bbcode should still exist in the database" )
2018-07-29 13:02:48 +00:00
// Bugs sometimes arise when we try to delete a hook when there are multiple, so test for that
// TODO: Do a finer grained test for that case...? A bigger test might catch more odd cases with multiple plugins
2019-04-19 08:20:10 +00:00
plugin2 , ok := c . Plugins [ "markdown" ]
2018-07-29 13:02:48 +00:00
expect ( t , ok , "Plugin markdown should exist" )
expect ( t , ! plugin2 . Installable , "Plugin markdown shouldn't be installable" )
expect ( t , ! plugin2 . Installed , "Plugin markdown shouldn't be 'installed'" )
expect ( t , ! plugin2 . Active , "Plugin markdown shouldn't be active" )
active , err = plugin2 . BypassActive ( )
expectNilErr ( t , err )
expect ( t , ! active , "Plugin markdown shouldn't be active in the database either" )
hasPlugin , err = plugin2 . InDatabase ( )
expectNilErr ( t , err )
expect ( t , ! hasPlugin , "Plugin markdown shouldn't exist in the database" )
expectNilErr ( t , plugin2 . AddToDatabase ( true , false ) )
2019-02-10 05:52:26 +00:00
expectNilErr ( t , plugin2 . Init ( plugin2 ) )
2018-07-29 13:02:48 +00:00
expectNilErr ( t , plugin . SetActive ( true ) )
2019-02-10 05:52:26 +00:00
expectNilErr ( t , plugin . Init ( plugin ) )
plugin2 . Deactivate ( plugin2 )
2018-07-29 13:02:48 +00:00
expectNilErr ( t , plugin2 . SetActive ( false ) )
2019-02-10 05:52:26 +00:00
plugin . Deactivate ( plugin )
2018-07-29 13:02:48 +00:00
expectNilErr ( t , plugin . SetActive ( false ) )
2018-07-31 04:02:09 +00:00
// Hook tests
2019-10-06 01:49:31 +00:00
ht := func ( ) * c . HookTable {
return c . GetHookTable ( )
}
expect ( t , ht ( ) . Sshook ( "haha" , "ho" ) == "ho" , "Sshook shouldn't have anything bound to it yet" )
2018-10-21 13:54:32 +00:00
handle := func ( in string ) ( out string ) {
2018-07-31 04:02:09 +00:00
return in + "hi"
}
plugin . AddHook ( "haha" , handle )
2019-10-06 01:49:31 +00:00
expect ( t , ht ( ) . Sshook ( "haha" , "ho" ) == "hohi" , "Sshook didn't give hohi" )
2018-07-31 04:02:09 +00:00
plugin . RemoveHook ( "haha" , handle )
2019-10-06 01:49:31 +00:00
expect ( t , ht ( ) . Sshook ( "haha" , "ho" ) == "ho" , "Sshook shouldn't have anything bound to it anymore" )
2018-10-21 13:54:32 +00:00
2019-10-06 01:49:31 +00:00
expect ( t , ht ( ) . Hook ( "haha" , "ho" ) == "ho" , "Hook shouldn't have anything bound to it yet" )
2018-10-21 13:54:32 +00:00
handle2 := func ( inI interface { } ) ( out interface { } ) {
return inI . ( string ) + "hi"
}
plugin . AddHook ( "hehe" , handle2 )
2019-10-06 01:49:31 +00:00
expect ( t , ht ( ) . Hook ( "hehe" , "ho" ) . ( string ) == "hohi" , "Hook didn't give hohi" )
2018-10-21 13:54:32 +00:00
plugin . RemoveHook ( "hehe" , handle2 )
2019-10-06 01:49:31 +00:00
expect ( t , ht ( ) . Hook ( "hehe" , "ho" ) . ( string ) == "ho" , "Hook shouldn't have anything bound to it anymore" )
2018-07-31 04:02:09 +00:00
// TODO: Add tests for more hook types
}
func TestPhrases ( t * testing . T ) {
2019-10-06 11:32:00 +00:00
getPhrase := phrases . GetPermPhrase
2019-10-06 00:34:09 +00:00
tp := func ( name string , expects string ) {
2019-10-06 01:49:31 +00:00
res := getPhrase ( name )
expect ( t , res == expects , "Not the expected phrase, got '" + res + "' instead" )
2019-10-06 00:34:09 +00:00
}
2019-10-06 01:49:31 +00:00
tp ( "BanUsers" , "Can ban users" )
tp ( "NoSuchPerm" , "{lang.perms[NoSuchPerm]}" )
tp ( "ViewTopic" , "Can view topics" )
tp ( "NoSuchPerm" , "{lang.perms[NoSuchPerm]}" )
2018-07-31 04:02:09 +00:00
// TODO: Cover the other phrase types, also try switching between languages to see if anything strange happens
2018-07-29 10:54:12 +00:00
}
2019-05-10 03:52:37 +00:00
func TestMetaStore ( t * testing . T ) {
m , err := c . Meta . Get ( "magic" )
2019-05-11 23:07:24 +00:00
expect ( t , m == "" , "meta var magic should be empty" )
recordMustNotExist ( t , err , "meta var magic should not exist" )
2019-05-17 08:40:41 +00:00
err = c . Meta . Set ( "magic" , "lol" )
expectNilErr ( t , err )
2019-05-11 23:07:24 +00:00
m , err = c . Meta . Get ( "magic" )
2019-05-17 08:40:41 +00:00
expectNilErr ( t , err )
expect ( t , m == "lol" , "meta var magic should be lol" )
2019-05-11 23:07:24 +00:00
2019-05-17 08:40:41 +00:00
err = c . Meta . Set ( "magic" , "wha" )
expectNilErr ( t , err )
2019-05-11 23:07:24 +00:00
2019-05-10 03:52:37 +00:00
m , err = c . Meta . Get ( "magic" )
2019-05-17 08:40:41 +00:00
expectNilErr ( t , err )
expect ( t , m == "wha" , "meta var magic should be wha" )
2019-05-11 23:07:24 +00:00
m , err = c . Meta . Get ( "giggle" )
expect ( t , m == "" , "meta var giggle should be empty" )
recordMustNotExist ( t , err , "meta var giggle should not exist" )
2019-05-10 03:52:37 +00:00
}
2019-11-09 02:34:12 +00:00
func TestPages ( t * testing . T ) {
expect ( t , c . Pages . Count ( ) == 0 , "Page count should be 0" )
_ , err := c . Pages . Get ( 1 )
recordMustNotExist ( t , err , "Page 1 should not exist yet" )
expectNilErr ( t , c . Pages . Delete ( - 1 ) )
expectNilErr ( t , c . Pages . Delete ( 0 ) )
expectNilErr ( t , c . Pages . Delete ( 1 ) )
_ , err = c . Pages . Get ( 1 )
recordMustNotExist ( t , err , "Page 1 should not exist yet" )
//err = c.Pages.Reload(1)
//recordMustNotExist(t,err,"Page 1 should not exist yet")
ipage := c . BlankCustomPage ( )
ipage . Name = "test"
ipage . Title = "Test"
ipage . Body = "A test page"
pid , err := ipage . Create ( )
expectNilErr ( t , err )
expect ( t , pid == 1 , "The first page should have an ID of 1" )
expect ( t , c . Pages . Count ( ) == 1 , "Page count should be 1" )
page , err := c . Pages . Get ( 1 )
expectNilErr ( t , err )
expect ( t , page . Name == ipage . Name , "The page name should be " + ipage . Name )
expect ( t , page . Title == ipage . Title , "The page title should be " + ipage . Title )
expect ( t , page . Body == ipage . Body , "The page body should be " + ipage . Body )
opage , err := c . Pages . Get ( 1 )
expectNilErr ( t , err )
opage . Name = "t"
opage . Title = "T"
opage . Body = "testing"
expectNilErr ( t , opage . Commit ( ) )
page , err = c . Pages . Get ( 1 )
expectNilErr ( t , err )
expect ( t , page . Name == opage . Name , "The page name should be " + opage . Name )
expect ( t , page . Title == opage . Title , "The page title should be " + opage . Title )
expect ( t , page . Body == opage . Body , "The page body should be " + opage . Body )
err = c . Pages . Delete ( 1 )
expectNilErr ( t , err )
expect ( t , c . Pages . Count ( ) == 0 , "Page count should be 0" )
_ , err = c . Pages . Get ( 1 )
recordMustNotExist ( t , err , "Page 1 should not exist" )
//err = c.Pages.Reload(1)
//recordMustNotExist(t,err,"Page 1 should not exist")
// TODO: More tests
}
2018-08-04 11:46:36 +00:00
func TestWordFilters ( t * testing . T ) {
// TODO: Test the word filters and their store
2019-04-19 08:20:10 +00:00
expect ( t , c . WordFilters . Length ( ) == 0 , "Word filter list should be empty" )
expect ( t , c . WordFilters . EstCount ( ) == 0 , "Word filter list should be empty" )
2019-06-01 12:31:48 +00:00
expect ( t , c . WordFilters . Count ( ) == 0 , "Word filter list should be empty" )
2019-04-19 08:20:10 +00:00
filters , err := c . WordFilters . GetAll ( )
2018-08-04 11:46:36 +00:00
expectNilErr ( t , err ) // TODO: Slightly confusing that we don't get ErrNoRow here
expect ( t , len ( filters ) == 0 , "Word filter map should be empty" )
// TODO: Add a test for ParseMessage relating to word filters
2019-11-09 02:34:12 +00:00
_ , err = c . WordFilters . Get ( 1 )
recordMustNotExist ( t , err , "filter 1 should not exist" )
2018-08-04 11:46:36 +00:00
2019-11-08 22:07:05 +00:00
wfid , err := c . WordFilters . Create ( "imbecile" , "lovely" )
2018-08-04 11:46:36 +00:00
expectNilErr ( t , err )
2019-11-09 02:34:12 +00:00
expect ( t , wfid == 1 , "The first word filter should have an ID of 1" )
2019-04-19 08:20:10 +00:00
expect ( t , c . WordFilters . Length ( ) == 1 , "Word filter list should not be empty" )
expect ( t , c . WordFilters . EstCount ( ) == 1 , "Word filter list should not be empty" )
2019-06-01 12:31:48 +00:00
expect ( t , c . WordFilters . Count ( ) == 1 , "Word filter list should not be empty" )
2019-11-08 22:07:05 +00:00
2019-04-19 08:20:10 +00:00
filters , err = c . WordFilters . GetAll ( )
2018-08-04 11:46:36 +00:00
expectNilErr ( t , err )
expect ( t , len ( filters ) == 1 , "Word filter map should not be empty" )
filter := filters [ 1 ]
expect ( t , filter . ID == 1 , "Word filter ID should be 1" )
expect ( t , filter . Find == "imbecile" , "Word filter needle should be imbecile" )
2019-11-10 02:37:53 +00:00
expect ( t , filter . Replace == "lovely" , "Word filter replacement should be lovely" )
2019-11-08 22:07:05 +00:00
filter , err = c . WordFilters . Get ( 1 )
expectNilErr ( t , err )
expect ( t , filter . ID == 1 , "Word filter ID should be 1" )
expect ( t , filter . Find == "imbecile" , "Word filter needle should be imbecile" )
2019-11-10 02:37:53 +00:00
expect ( t , filter . Replace == "lovely" , "Word filter replacement should be lovely" )
2019-11-08 22:07:05 +00:00
2019-11-09 02:34:12 +00:00
// Update
expectNilErr ( t , c . WordFilters . Update ( 1 , "b" , "a" ) )
expect ( t , c . WordFilters . Length ( ) == 1 , "Word filter list should not be empty" )
expect ( t , c . WordFilters . EstCount ( ) == 1 , "Word filter list should not be empty" )
expect ( t , c . WordFilters . Count ( ) == 1 , "Word filter list should not be empty" )
filters , err = c . WordFilters . GetAll ( )
expectNilErr ( t , err )
expect ( t , len ( filters ) == 1 , "Word filter map should not be empty" )
filter = filters [ 1 ]
expect ( t , filter . ID == 1 , "Word filter ID should be 1" )
expect ( t , filter . Find == "b" , "Word filter needle should be b" )
2019-11-10 02:37:53 +00:00
expect ( t , filter . Replace == "a" , "Word filter replacement should be a" )
2019-11-09 02:34:12 +00:00
filter , err = c . WordFilters . Get ( 1 )
expectNilErr ( t , err )
expect ( t , filter . ID == 1 , "Word filter ID should be 1" )
expect ( t , filter . Find == "b" , "Word filter needle should be imbecile" )
2019-11-10 02:37:53 +00:00
expect ( t , filter . Replace == "a" , "Word filter replacement should be a" )
2019-11-09 02:34:12 +00:00
2018-08-04 11:46:36 +00:00
// TODO: Add a test for ParseMessage relating to word filters
2019-11-08 22:07:05 +00:00
err = c . WordFilters . Delete ( 1 )
2019-11-09 02:34:12 +00:00
expectNilErr ( t , err )
expect ( t , c . WordFilters . Length ( ) == 0 , "Word filter list should be empty" )
expect ( t , c . WordFilters . EstCount ( ) == 0 , "Word filter list should be empty" )
expect ( t , c . WordFilters . Count ( ) == 0 , "Word filter list should be empty" )
filters , err = c . WordFilters . GetAll ( )
expectNilErr ( t , err ) // TODO: Slightly confusing that we don't get ErrNoRow here
expect ( t , len ( filters ) == 0 , "Word filter map should be empty" )
_ , err = c . WordFilters . Get ( 1 )
recordMustNotExist ( t , err , "filter 1 should not exist" )
// TODO: Any more tests we could do?
2018-08-04 11:46:36 +00:00
}
2019-01-21 12:27:59 +00:00
// TODO: Expand upon the valid characters which can go in URLs?
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
func TestSlugs ( t * testing . T ) {
2019-10-06 00:34:09 +00:00
l := & MEPairList { nil }
2019-04-19 08:20:10 +00:00
c . Config . BuildSlugs = true // Flip this switch, otherwise all the tests will fail
2017-09-03 04:50:31 +00:00
2019-10-06 00:34:09 +00:00
l . Add ( "Unknown" , "unknown" )
l . Add ( "Unknown2" , "unknown2" )
l . Add ( "Unknown " , "unknown" )
l . Add ( "Unknown 2" , "unknown-2" )
l . Add ( "Unknown 2" , "unknown-2" )
l . Add ( "Admin Alice" , "admin-alice" )
l . Add ( "Admin_Alice" , "adminalice" )
l . Add ( "Admin_Alice-" , "adminalice" )
l . Add ( "-Admin_Alice-" , "adminalice" )
l . Add ( "-Admin@Alice-" , "adminalice" )
l . Add ( "-Admin😀Alice-" , "adminalice" )
l . Add ( "u" , "u" )
l . Add ( "" , "untitled" )
l . Add ( " " , "untitled" )
l . Add ( "-" , "untitled" )
l . Add ( "--" , "untitled" )
l . Add ( "é" , "é" )
l . Add ( "-é-" , "é" )
l . Add ( "-你好-" , "untitled" )
l . Add ( "-こにちは-" , "untitled" )
for _ , item := range l . Items {
2017-09-03 04:50:31 +00:00
t . Log ( "Testing string '" + item . Msg + "'" )
2019-10-06 00:34:09 +00:00
res := c . NameToSlug ( item . Msg )
2017-09-03 04:50:31 +00:00
if res != item . Expects {
t . Error ( "Bad output:" , "'" + res + "'" )
t . Error ( "Expected:" , item . Expects )
}
}
Added the Social Groups plugin. This is still under construction.
Made a few improvements to the ForumStore, including bringing it's API closer in line with the other datastores, adding stubs for future subforum functionality, and improving efficiency in a few places.
The auth interface now handles all the authentication stuff.
Renamed the debug config variable to debug_mode.
Added the PluginPerms API.
Internal Errors will now dump the stack trace in the console.
Added support for installable plugins.
Refactored the routing logic so that the router now handles the common PreRoute logic(exc. /static/)
Added the CreateTable method to the query generator. It might need some tweaking to better support other database systems.
Added the same CreateTable method to the query builder.
Began work on PostgreSQL support.
Added the string-string hook type
Added the pre_render hook type.
Added the ParentID and ParentType fields to forums.
Added the get_forum_url_prefix function.
Added a more generic build_slug function.
Added the get_topic_url_prefix function.
Added the override_perms and override_forum_perms functions for bulk setting and unsetting permissions.
Added more ExtData fields in a few structs and removed them on the Perms struct as the PluginPerms API supersedes them there.
Plugins can now see the router instance.
The plugin initialisation handlers can now throw errors.
Plugins are now initialised after all the forum's subsystems are.
Refactored the unit test logic. For instance, we now use the proper .Log method rather than fmt.Println in many cases.
Sorry, we'll have to break Github's generated file detection, as the build instructions aren't working, unless I put them at the top, and they're far, far more important than getting Github to recognise the generated code as generated code.
Fixed an issue with mysql.go's _init_database() overwriting the dbpassword variable. Not a huge issue, but it is a "gotcha" for those not expecting a ':' at the start.
Fixed an issue with forum creation where the forum permissions didn't get cached.
Fixed a bug in plugin_bbcode where negative numbers in rand would crash Gosora.
Made the outputs of plugin_markdown and plugin_bbcode more compliant with the tests.
Revamped the phrase system to make it easier for us to add language pack related features in the future.
Added the WidgetMenu widget type.
Revamped the theme again. I'm experimenting to see which approach I like most.
- Excuse the little W3C rage. Some things about CSS drive me crazy :p
Tests:
Added 22 bbcode_full_parse tests.
Added 19 bbcode_regex_parse tests.
Added 27 markdown_parse tests.
Added four UserStore tests. More to come when the test database functionality is added.
Added 18 name_to_slug tests.
Hooks:
Added the pre_render hook.
Added the pre_render_forum_list hook.
Added the pre_render_view_forum hook.
Added the pre_render_topic_list hook.
Added the pre_render_view_topic hook.
Added the pre_render_profile hook.
Added the pre_render_custom_page hook.
Added the pre_render_overview hook.
Added the pre_render_create_topic hook.
Added the pre_render_account_own_edit_critical hook.
Added the pre_render_account_own_edit_avatar hook.
Added the pre_render_account_own_edit_username hook.
Added the pre_render_account_own_edit_email hook.
Added the pre_render_login hook.
Added the pre_render_register hook.
Added the pre_render_ban hook.
Added the pre_render_panel_dashboard hook.
Added the pre_render_panel_forums hook.
Added the pre_render_panel_delete_forum hook.
Added the pre_render_panel_edit_forum hook.
Added the pre_render_panel_settings hook.
Added the pre_render_panel_setting hook.
Added the pre_render_panel_plugins hook.
Added the pre_render_panel_users hook.
Added the pre_render_panel_edit_user hook.
Added the pre_render_panel_groups hook.
Added the pre_render_panel_edit_group hook.
Added the pre_render_panel_edit_group_perms hook.
Added the pre_render_panel_themes hook.
Added the pre_render_panel_mod_log hook.
Added the pre_render_error hook.
Added the pre_render_security_error hook.
Added the create_group_preappend hook.
Added the intercept_build_widgets hook.
Added the simple_forum_check_pre_perms hook.
Added the forum_check_pre_perms hook.
2017-07-09 12:06:04 +00:00
}
2017-07-12 11:05:18 +00:00
2019-01-21 12:27:59 +00:00
func TestWidgets ( t * testing . T ) {
2019-04-19 08:20:10 +00:00
_ , err := c . Widgets . Get ( 1 )
2019-01-21 12:27:59 +00:00
recordMustNotExist ( t , err , "There shouldn't be any widgets by default" )
2019-04-19 08:20:10 +00:00
widgets := c . Docks . RightSidebar . Items
2019-01-21 12:27:59 +00:00
expect ( t , len ( widgets ) == 0 , fmt . Sprintf ( "RightSidebar should have 0 items, not %d" , len ( widgets ) ) )
2019-04-19 08:20:10 +00:00
widget := & c . Widget { Position : 0 , Side : "rightSidebar" , Type : "simple" , Enabled : true , Location : "global" }
ewidget := & c . WidgetEdit { widget , map [ string ] string { "Name" : "Test" , "Text" : "Testing" } }
2019-11-10 02:37:53 +00:00
wid , err := ewidget . Create ( )
2019-01-21 12:27:59 +00:00
expectNilErr ( t , err )
2019-11-10 02:37:53 +00:00
expect ( t , wid == 1 , "wid should be 1" )
2019-01-21 12:27:59 +00:00
// TODO: Do a test for the widget body
2019-04-19 08:20:10 +00:00
widget2 , err := c . Widgets . Get ( 1 )
2019-01-21 12:27:59 +00:00
expectNilErr ( t , err )
expect ( t , widget2 . Position == widget . Position , "wrong position" )
expect ( t , widget2 . Side == widget . Side , "wrong side" )
expect ( t , widget2 . Type == widget . Type , "wrong type" )
expect ( t , widget2 . Enabled , "not enabled" )
expect ( t , widget2 . Location == widget . Location , "wrong location" )
2019-04-19 08:20:10 +00:00
widgets = c . Docks . RightSidebar . Items
2019-01-21 12:27:59 +00:00
expect ( t , len ( widgets ) == 1 , fmt . Sprintf ( "RightSidebar should have 1 item, not %d" , len ( widgets ) ) )
expect ( t , widgets [ 0 ] . Position == widget . Position , "wrong position" )
expect ( t , widgets [ 0 ] . Side == widget . Side , "wrong side" )
expect ( t , widgets [ 0 ] . Type == widget . Type , "wrong type" )
expect ( t , widgets [ 0 ] . Enabled , "not enabled" )
expect ( t , widgets [ 0 ] . Location == widget . Location , "wrong location" )
widget2 . Enabled = false
2019-04-19 08:20:10 +00:00
ewidget = & c . WidgetEdit { widget2 , map [ string ] string { "Name" : "Test" , "Text" : "Testing" } }
2019-01-21 12:27:59 +00:00
err = ewidget . Commit ( )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
widget2 , err = c . Widgets . Get ( 1 )
2019-01-21 12:27:59 +00:00
expectNilErr ( t , err )
expect ( t , widget2 . Position == widget . Position , "wrong position" )
expect ( t , widget2 . Side == widget . Side , "wrong side" )
expect ( t , widget2 . Type == widget . Type , "wrong type" )
expect ( t , ! widget2 . Enabled , "not enabled" )
expect ( t , widget2 . Location == widget . Location , "wrong location" )
2019-04-19 08:20:10 +00:00
widgets = c . Docks . RightSidebar . Items
2019-01-21 12:27:59 +00:00
expect ( t , len ( widgets ) == 1 , fmt . Sprintf ( "RightSidebar should have 1 item, not %d" , len ( widgets ) ) )
expect ( t , widgets [ 0 ] . Position == widget . Position , "wrong position" )
expect ( t , widgets [ 0 ] . Side == widget . Side , "wrong side" )
expect ( t , widgets [ 0 ] . Type == widget . Type , "wrong type" )
expect ( t , ! widgets [ 0 ] . Enabled , "not enabled" )
expect ( t , widgets [ 0 ] . Location == widget . Location , "wrong location" )
err = widget2 . Delete ( )
expectNilErr ( t , err )
2019-04-19 08:20:10 +00:00
_ , err = c . Widgets . Get ( 1 )
2019-01-21 12:27:59 +00:00
recordMustNotExist ( t , err , "There shouldn't be any widgets anymore" )
2019-04-19 08:20:10 +00:00
widgets = c . Docks . RightSidebar . Items
2019-01-21 12:27:59 +00:00
expect ( t , len ( widgets ) == 0 , fmt . Sprintf ( "RightSidebar should have 0 items, not %d" , len ( widgets ) ) )
}
2017-07-12 11:05:18 +00:00
func TestAuth ( t * testing . T ) {
2017-09-03 04:50:31 +00:00
// bcrypt likes doing stupid things, so this test will probably fail
2018-05-28 06:27:12 +00:00
realPassword := "Madame Cassandra's Mystic Orb"
2017-11-13 05:22:37 +00:00
t . Logf ( "Set realPassword to '%s'" , realPassword )
2018-05-28 06:27:12 +00:00
t . Log ( "Hashing the real password with bcrypt" )
2019-04-19 08:20:10 +00:00
hashedPassword , _ , err := c . BcryptGeneratePassword ( realPassword )
2018-05-28 06:27:12 +00:00
if err != nil {
t . Error ( err )
}
passwordTest ( t , realPassword , hashedPassword )
// TODO: Peek at the prefix to verify this is a bcrypt hash
2017-09-03 04:50:31 +00:00
t . Log ( "Hashing the real password" )
2019-04-19 08:20:10 +00:00
hashedPassword2 , _ , err := c . GeneratePassword ( realPassword )
2017-09-03 04:50:31 +00:00
if err != nil {
t . Error ( err )
}
2018-05-28 06:27:12 +00:00
passwordTest ( t , realPassword , hashedPassword2 )
// TODO: Peek at the prefix to verify this is a bcrypt hash
2019-04-19 08:20:10 +00:00
_ , err , _ = c . Auth . Authenticate ( "None" , "password" )
2018-05-28 06:27:12 +00:00
errmsg := "Username None shouldn't exist"
if err != nil {
errmsg += "\n" + err . Error ( )
}
2019-04-19 08:20:10 +00:00
expect ( t , err == c . ErrNoUserByName , errmsg )
2018-05-28 06:27:12 +00:00
2019-04-19 08:20:10 +00:00
uid , err , _ := c . Auth . Authenticate ( "Admin" , "password" )
2018-05-28 06:27:12 +00:00
expectNilErr ( t , err )
expect ( t , uid == 1 , fmt . Sprintf ( "Default admin uid should be 1 not %d" , uid ) )
2019-04-19 08:20:10 +00:00
_ , err , _ = c . Auth . Authenticate ( "Sam" , "ReallyBadPassword" )
2018-05-28 06:27:12 +00:00
errmsg = "Username Sam shouldn't exist"
if err != nil {
errmsg += "\n" + err . Error ( )
}
2019-04-19 08:20:10 +00:00
expect ( t , err == c . ErrNoUserByName , errmsg )
2018-05-28 06:27:12 +00:00
2019-04-19 08:20:10 +00:00
admin , err := c . Users . Get ( 1 )
2018-05-28 06:27:12 +00:00
expectNilErr ( t , err )
// TODO: Move this into the user store tests to provide better coverage? E.g. To see if the installer and the user creator initialise the field differently
expect ( t , admin . Session == "" , "Admin session should be blank" )
2017-09-03 04:50:31 +00:00
2019-04-19 08:20:10 +00:00
session , err := c . Auth . CreateSession ( 1 )
2018-05-28 06:27:12 +00:00
expectNilErr ( t , err )
expect ( t , session != "" , "Admin session shouldn't be blank" )
// TODO: Test the actual length set in the setting in addition to this "too short" test
// TODO: We might be able to push up this minimum requirement
expect ( t , len ( session ) > 10 , "Admin session shouldn't be too short" )
expect ( t , admin . Session != session , "Old session should not match new one" )
2019-04-19 08:20:10 +00:00
admin , err = c . Users . Get ( 1 )
2018-05-28 06:27:12 +00:00
expectNilErr ( t , err )
expect ( t , admin . Session == session , "Sessions should match" )
2018-10-04 02:58:01 +00:00
// TODO: Create a user with a unicode password and see if we can login as them
2018-05-28 06:27:12 +00:00
// TODO: Tests for SessionCheck, GetCookies, and ForceLogout
}
// TODO: Vary the salts? Keep in mind that some algorithms store the salt in the hash therefore the salt string may be blank
func passwordTest ( t * testing . T , realPassword string , hashedPassword string ) {
if len ( hashedPassword ) < 10 {
t . Error ( "Hash too short" )
}
salt := ""
password := realPassword
2017-11-13 05:22:37 +00:00
t . Logf ( "Testing password '%s'" , password )
t . Logf ( "Testing salt '%s'" , salt )
2019-04-19 08:20:10 +00:00
err := c . CheckPassword ( hashedPassword , password , salt )
if err == c . ErrMismatchedHashAndPassword {
2017-09-03 04:50:31 +00:00
t . Error ( "The two don't match" )
2019-04-19 08:20:10 +00:00
} else if err == c . ErrPasswordTooLong {
2017-09-03 04:50:31 +00:00
t . Error ( "CheckPassword thinks the password is too long" )
} else if err != nil {
t . Error ( err )
}
password = "hahaha"
2017-11-13 05:22:37 +00:00
t . Logf ( "Testing password '%s'" , password )
t . Logf ( "Testing salt '%s'" , salt )
2019-04-19 08:20:10 +00:00
err = c . CheckPassword ( hashedPassword , password , salt )
if err == c . ErrPasswordTooLong {
2017-09-03 04:50:31 +00:00
t . Error ( "CheckPassword thinks the password is too long" )
} else if err == nil {
t . Error ( "The two shouldn't match!" )
}
password = "Madame Cassandra's Mystic"
2017-11-13 05:22:37 +00:00
t . Logf ( "Testing password '%s'" , password )
t . Logf ( "Testing salt '%s'" , salt )
2019-04-19 08:20:10 +00:00
err = c . CheckPassword ( hashedPassword , password , salt )
expect ( t , err != c . ErrPasswordTooLong , "CheckPassword thinks the password is too long" )
2017-11-13 05:22:37 +00:00
expect ( t , err != nil , "The two shouldn't match!" )
2017-07-12 11:05:18 +00:00
}
2018-06-26 02:30:29 +00:00
2018-06-26 04:54:20 +00:00
type METri struct {
Name string // Optional, this is here for tests involving invisible characters so we know what's going in
Msg string
Expects string
}
2018-10-08 04:38:51 +00:00
type METriList struct {
Items [ ] METri
}
2019-10-06 00:34:09 +00:00
func ( l * METriList ) Add ( args ... string ) {
2018-06-26 04:54:20 +00:00
if len ( args ) < 2 {
panic ( "need 2 or more args" )
}
if len ( args ) > 2 {
2019-10-06 00:34:09 +00:00
l . Items = append ( l . Items , METri { args [ 0 ] , args [ 1 ] , args [ 2 ] } )
2018-10-08 04:38:51 +00:00
} else {
2019-10-06 00:34:09 +00:00
l . Items = append ( l . Items , METri { "" , args [ 0 ] , args [ 1 ] } )
2018-06-26 04:54:20 +00:00
}
}
2018-10-04 09:01:07 +00:00
type CountTest struct {
Name string
Msg string
Expects int
}
type CountTestList struct {
Items [ ] CountTest
}
2019-10-06 00:34:09 +00:00
func ( l * CountTestList ) Add ( name string , msg string , expects int ) {
l . Items = append ( l . Items , CountTest { name , msg , expects } )
2018-10-04 09:01:07 +00:00
}
func TestWordCount ( t * testing . T ) {
2019-10-06 00:34:09 +00:00
l := & CountTestList { nil }
l . Add ( "blank" , "" , 0 )
l . Add ( "single-letter" , "h" , 1 )
l . Add ( "single-kana" , "お" , 1 )
l . Add ( "single-letter-words" , "h h" , 2 )
l . Add ( "two-letter" , "h" , 1 )
l . Add ( "two-kana" , "おは" , 1 )
l . Add ( "two-letter-words" , "hh hh" , 2 )
l . Add ( "" , "h,h" , 2 )
l . Add ( "" , "h,,h" , 2 )
l . Add ( "" , "h, h" , 2 )
l . Add ( "" , " h, h" , 2 )
l . Add ( "" , "h, h " , 2 )
l . Add ( "" , " h, h " , 2 )
l . Add ( "" , "h, h" , 2 )
l . Add ( "" , "h\nh" , 2 )
l . Add ( "" , "h\"h" , 2 )
l . Add ( "" , "h[r]h" , 3 )
l . Add ( "" , "お,お" , 2 )
l . Add ( "" , "お、お" , 2 )
l . Add ( "" , "お\nお" , 2 )
l . Add ( "" , "お”お" , 2 )
l . Add ( "" , "お「あ」お" , 3 )
for _ , item := range l . Items {
2019-04-19 08:20:10 +00:00
res := c . WordCount ( item . Msg )
2018-10-04 09:01:07 +00:00
if res != item . Expects {
if item . Name != "" {
t . Error ( "Name: " , item . Name )
}
t . Error ( "Testing string '" + item . Msg + "'" )
t . Error ( "Bad output:" , res )
t . Error ( "Expected:" , item . Expects )
}
}
}