a
/
code-server
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix file open overflow on Firefox

This commit is contained in:
Asher 2019-02-26 15:09:59 -06:00
parent f05ce105e8
commit a07d0c9c3d
No known key found for this signature in database
GPG Key ID: 7BB4BA9C783D2BBC
2 changed files with 118 additions and 119 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/vscode/src/dialog.scss
View File

@ -62,11 +62,6 @@
} }
} }
.file-area {
flex: 1;
display: flex;
flex-direction: column;
.dialog-grid { .dialog-grid {
display: grid; display: grid;
grid-template-columns: 2fr 0.2fr 0.8fr; grid-template-columns: 2fr 0.2fr 0.8fr;
@ -77,6 +72,12 @@
font-size: 12px; font-size: 12px;
} }
.file-area {
flex: 1;
display: flex;
flex-direction: column;
overflow: hidden;
.dialog-entry { .dialog-entry {
cursor: pointer; cursor: pointer;
font-size: 1.2em; font-size: 1.2em;
@ -92,9 +93,7 @@
.dialog-entry-icon { .dialog-entry-icon {
width: 16px; width: 16px;
height: 19px; height: 19px;
display: inline-block;
margin-right: 5px; margin-right: 5px;
margin-bottom: -3px;
} }
&:hover { &:hover {

10
packages/vscode/src/dialog.ts
View File

@ -167,10 +167,6 @@ class Dialog {
navItems.appendChild(this.pathNode); navItems.appendChild(this.pathNode);
this.root.appendChild(navItems); this.root.appendChild(navItems);
const fileAreaNode = document.createElement("div");
fileAreaNode.classList.add("file-area");
fileAreaNode.classList.add("show-file-icons");
const headingsNode = document.createElement("div"); const headingsNode = document.createElement("div");
headingsNode.className = "headings dialog-grid"; headingsNode.className = "headings dialog-grid";
["Name", "Size", "Last Modified"].forEach(e => { ["Name", "Size", "Last Modified"].forEach(e => {
@ -178,10 +174,14 @@ class Dialog {
header.innerText = e; header.innerText = e;
headingsNode.appendChild(header); headingsNode.appendChild(header);
}); });
this.root.appendChild(headingsNode);
const fileAreaNode = document.createElement("div");
fileAreaNode.classList.add("file-area");
fileAreaNode.classList.add("show-file-icons");
this.filesNode = document.createElement("div"); this.filesNode = document.createElement("div");
this.filesNode.className = "files-list"; this.filesNode.className = "files-list";
fileAreaNode.appendChild(headingsNode);
this.entryList = new ObjectTree<DialogEntry, string>(this.filesNode, { this.entryList = new ObjectTree<DialogEntry, string>(this.filesNode, {
getHeight: (entry: DialogEntry): number => { getHeight: (entry: DialogEntry): number => {
return 20; return 20;