code-server/docs/CONTRIBUTING.md

172 lines
5.7 KiB
Markdown
Raw Normal View History

<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
2020-02-19 00:07:01 +00:00
# Contributing
2021-03-15 22:13:44 +00:00
- [Contributing](#contributing)
- [Pull Requests](#pull-requests)
- [Requirements](#requirements)
- [Development Workflow](#development-workflow)
- [Updating VS Code](#updating-vs-code)
- [Notes about Changes](#notes-about-changes)
- [Build](#build)
- [Structure](#structure)
- [Modifications to VS Code](#modifications-to-vs-code)
- [Currently Known Issues](#currently-known-issues)
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
- [Detailed CI and build process docs](../ci)
## Pull Requests
Please create a [GitHub Issue](https://github.com/cdr/code-server/issues) for each issue
you'd like to address unless the proposed fix is minor.
In your Pull Requests (PR), link to the issue that the PR solves.
Please ensure that the base of your PR is the **master** branch. (Note: The default
GitHub branch is the latest release branch, though you should point all of your changes to be merged into
master).
## Requirements
The prerequisites for contributing to code-server are almost the same as those for
[VS Code](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites).
There are several differences, however. You must:
- Use Node.js version 12.x (or greater)
- Have [yarn](https://classic.yarnpkg.com/en/) installed (which is used to install JS packages and run development scripts)
- Have [nfpm](https://github.com/goreleaser/nfpm) (which is used to build `.deb` and `.rpm` packages and [jq](https://stedolan.github.io/jq/) (used to build code-server releases) installed
2020-02-19 00:07:01 +00:00
The [CI container](../ci/images/debian10/Dockerfile) is a useful reference for all
of the dependencies code-server uses.
## Development Workflow
2020-02-19 00:07:01 +00:00
```shell
yarn
2020-05-17 20:53:08 +00:00
yarn watch
# Visit http://localhost:8080 once the build is completed.
2020-02-19 00:07:01 +00:00
```
To develop inside an isolated Docker container:
2020-04-14 22:22:52 +00:00
```shell
2020-09-03 06:16:57 +00:00
./ci/dev/image/run.sh yarn
./ci/dev/image/run.sh yarn watch
2020-04-14 22:22:52 +00:00
```
`yarn watch` will live reload changes to the source.
2020-02-19 00:07:01 +00:00
2020-12-17 21:08:51 +00:00
### Updating VS Code
To update VS Code, follow these steps:
2021-02-26 22:46:31 +00:00
1. Run `yarn update:vscode`.
2. Enter a version. Ex. 1.53
3. This will open a draft PR for you.
4. There will be merge conflicts. First commit them.
1. We do this because if we don't, it will be impossible to review your PR.
5. Once they're all fixed, test code-server locally and make sure it all works.
2020-12-17 21:08:51 +00:00
#### Notes about Changes
- watch out for updates to `lib/vscode/src/vs/code/browser/workbench/workbench.html`. You may need to make changes to `src/browser/pages/vscode.html`
2020-12-17 21:08:51 +00:00
2020-02-19 00:07:01 +00:00
## Build
You can build using:
```shell
2020-09-03 06:16:57 +00:00
./ci/dev/image/run.sh ./ci/steps/release.sh
```
Run your build with:
```shell
cd release
yarn --production
# Runs the built JavaScript with Node.
node .
```
Build the release packages (make sure that you run `./ci/steps/release.sh` first):
```shell
IMAGE=centos7 ./ci/dev/image/run.sh ./ci/steps/release-packages.sh
# The standalone release is in ./release-standalone
# .deb, .rpm and the standalone archive are in ./release-packages
```
The `release.sh` script is equal to running:
2020-02-19 00:07:01 +00:00
```shell
yarn
yarn build
yarn build:vscode
yarn release
2020-02-19 00:07:01 +00:00
```
And `release-packages.sh` is equal to:
```shell
2020-05-27 20:39:17 +00:00
yarn release:standalone
yarn test:standalone-release
yarn package
```
For a faster release build, you can run instead:
2020-10-07 17:26:57 +00:00
```shell
2020-10-07 17:26:57 +00:00
KEEP_MODULES=1 ./ci/steps/release.sh
node ./release
```
2020-05-17 20:53:08 +00:00
## Structure
The `code-server` script serves an HTTP API for login and starting a remote VS Code process.
2020-05-17 20:53:08 +00:00
2021-02-25 19:15:28 +00:00
The CLI code is in [src/node](../src/node) and the HTTP routes are implemented in
[src/node/routes](../src/node/routes).
2020-05-17 20:53:08 +00:00
2021-02-25 19:15:28 +00:00
Most of the meaty parts are in the VS Code portion of the codebase under [lib/vscode](../lib/vscode), which we described next.
2020-05-17 20:53:08 +00:00
2020-12-16 21:56:14 +00:00
### Modifications to VS Code
2020-05-17 20:53:08 +00:00
In v1 of code-server, we had a patch of VS Code that split the codebase into a front-end
and a server. The front-end consisted of all UI code, while the server ran the extensions
and exposed an API to the front-end for file access and all UI needs.
2020-05-17 20:53:08 +00:00
Over time, Microsoft added support to VS Code to run it on the web. They have made
the front-end open source, but not the server. As such, code-server v2 (and later) uses
2021-02-25 19:15:28 +00:00
the VS Code front-end and implements the server. We do this by using a git subtree to fork and modify VS Code. This code lives under [lib/vscode](../lib/vscode).
2020-05-17 20:53:08 +00:00
2020-12-16 23:50:35 +00:00
Some noteworthy changes in our version of VS Code:
2020-05-17 20:53:08 +00:00
- Adding our build file, which includes our code and VS Code's web code
- Allowing multiple extension directories (both user and built-in)
- Modifying the loader, websocket, webview, service worker, and asset requests to
use the URL of the page as a base (and TLS, if necessary for the websocket)
- Sending client-side telemetry through the server
- Allowing modification of the display language
- Making it possible for us to load code on the client
- Making it possible to install extensions of any kind
- Fixing issue with getting disconnected when your machine sleeps or hibernates
- Adding connection type to web socket query parameters
As the web portion of VS Code matures, we'll be able to shrink and possibly
2020-12-16 23:50:35 +00:00
eliminate our modifications. In the meantime, upgrading the VS Code version requires
us to ensure that our changes are still applied and work as intended. In the future,
we'd like to run VS Code unit tests against our builds to ensure that features
work as expected.
2020-05-17 20:53:08 +00:00
**Note**: We have [extension docs](../ci/README.md) on the CI and build system.
2020-05-17 20:53:08 +00:00
If the functionality you're working on does NOT depend on code from VS Code, please
move it out and into code-server.
2020-05-17 20:53:08 +00:00
### Currently Known Issues
2020-05-17 20:53:08 +00:00
- Creating custom VS Code extensions and debugging them doesn't work
- Extension profiling and tips are currently disabled