- Don't use "any" for the API type.
- Remove everything from the Coder API that can eventually be done
through the VS Code API.
- Move the event emission to our own client to minimize patching.
Since this will be a path in the binary that we don't want to create on
the user's system. I also removed the option to override it; it doesn't
seem like a great idea since you'd always want those builtin extensions.
This way we also don't have to check if the option was passed and only
create it if that was the case.
This isn't a real error event; we artificially emit it just in case
something waiting to start is listening to the error event in order to
clean up and/or restart.
* Allow setting paths for builtin exts and extra dirs
The extra directories aren't used yet, just available from the
environment service and to the shared process.
* Utilize extra builtin extensions path
* Utilize extra extensions directory
* Fix cached mtimes for extra extension dirs
* Simplify extension cache equality check
* Update VS Code to 1.33.0
* Fix slow file tree
* Fix WindowsService fill
* Provide `off` on event listeners
* Fix webview
* Fix double title bar and missing preferences on Mac
* Bump VS Code version in Travis config
* Fix black dialog text (again)
* Fix shared process not starting
Registering returns an instance that lets you retry and recover without
needing to keep passing the name everywhere.
Also refactored the shared process a little to make better use of the
retry and downgraded stderr messages to warnings because they aren't
critical.
* Make proxies decide how to handle disconnects
* Connect to a new terminal instance on disconnect
* Use our retry for the watcher
* Specify method when proxy doesn't exist
* Don't error when closing/killing disconnected proxy
* Specify proxy ID when a method doesn't exist
* Use our retry for the searcher
Also dispose some things for the watcher because it doesn't seem that
was done properly.
The searcher also now starts immediately so there won't be lag when you
perform your first search.
* Use our retry for the extension host
* Emit error in parent proxy class
Reduces duplicate code. Not all items are "supposed" to have an error
event according to the original implementation we are filling, but there
is no reason why we can't emit our own events (and are already doing so
for the "disconnected" event anyway).
* Reconnect spdlog
* Add error message when shared process disconnects
* Pass method resolve to parse
* Don't pass method to getProxy
It doesn't tell you anything that trace logging wouldn't and has
no relation to what the function actually does.
* Fix infinite recursion when disposing protocol client in tests
* Replace evaluations with proxies and messages
* Return proxies synchronously
Otherwise events can be lost.
* Ensure events cannot be missed
* Refactor remaining fills
* Use more up-to-date version of util
For callbackify.
* Wait for dispose to come back before removing
This prevents issues with the "done" event not always being the last
event fired. For example a socket might close and then end, but only
if the caller called end.
* Remove old node-pty tests
* Fix emitting events twice on duplex streams
* Preserve environment when spawning processes
* Throw a better error if the proxy doesn't exist
* Remove rimraf dependency from ide
* Update net.Server.listening
* Use exit event instead of killed
Doesn't look like killed is even a thing.
* Add response timeout to server
* Fix trash
* Require node-pty & spdlog after they get unpackaged
This fixes an error when running in the binary.
* Fix errors in down emitter preventing reconnecting
* Fix disposing proxies when nothing listens to "error" event
* Refactor event tests to use jest.fn()
* Reject proxy call when disconnected
Otherwise it'll wait for the timeout which is a waste of time since we
already know the connection is dead.
* Use nbin for binary packaging
* Remove additional module requires
* Attempt to remove require for local bootstrap-fork
* Externalize fsevents
There is a window between when the stat is made and the result makes it
back to the client where a file is created or deleted and it won't be a
part of that stat.
To fix it, I added a new property signaling that we got some changes
since starting the stat and should run the stat again because we have no
way of knowing whether the currently running stat will include the new
changes or not.
* Update VS Code to 1.32.0
* Update patch
Most changes are moved files, most notably shell.contribution.ts which
is now main.contribution.ts.
Also:
- repl.ts no longer uses isMacintosh
- shell.ts doesn't exist
- added back the commented-out CSP headers
* Use es6 target for bootstrap-fork
* Directly reference cross-env binary
yarn and npm find the binary just fine when running the tasks from the
root but it doesn't work if you run one of those tasks directly from
within those directories.
* Update import paths and bootstrap-fork ignores
* Increase memory limit for building default extensions
* Fix invalid regex in Firefox
* Update startup function
* Fix global.require error
* Update zip extract arguments
* Update travis to minimum required Node version
* Always chmod executable dependencies
Fixes EACCESS errors for users that had the files unpacked before we
added the chmod call.
* Remove unused var declaration
* Allow setting marketplace URL
* Add zip fill
* Comment out CSP for now
* Fill zip on client as well
Probably will need it for client-side extensions.
* Don't use itemUrl (it's undefined)
* Remove extension rating
* Hide ratings with CSS instead of patching them out
* Add hard-coded fallback for service URL
* Only use coder-develop for extapi if env is explicitly development
* Don't use coder-develop at all for extapi
If you need it, you can set SERVICE_URL.
* Add windows support
* Improve multi-platform support
* Install with network-concurrency 1
* Use file-glob to upload windows binary
* Don't install packages in parallel if on windows
* Rename vscode-remote to code-server
* Add output at intervals so CI doesn't kill build
* Update all tasks to provide timed output
* Don't perform tasks sync otherwise we can't log
* Set platform based on server
Had to refactor a bit to ensure our values get set before VS Code tries
to use them.
* Pave the way for mnemonics on all platforms
* Fix context menus on Mac
* Fix a bunch of things on Mac including menu bar
* Set keybindings based on client's OS
* Add trace log level
* Use active eval to implement spdlog
* Split server/client active eval interfaces
Since all properties are *not* valid on both sides
* +200% fire resistance
* Implement exec using active evaluations
* Fully implement child process streams
* Watch impl, move child_process back to explicitly adding events
Automatically forwarding all events might be the right move, but wanna
think/discuss it a bit more because it didn't come out very cleanly.
* Would you like some args with that callback?
* Implement the rest of child_process using active evals
* Rampant memory leaks
Emit "kill" to active evaluations when client disconnects in order to
kill processes. Most likely won't be the final solution.
* Resolve some minor issues with output panel
* Implement node-pty with active evals
* Provide clearTimeout to vm sandbox
* Implement socket with active evals
* Extract some callback logic
Also remove some eval interfaces, need to re-think those.
* Implement net.Server and remainder of net.Socket using active evals
* Implement dispose for active evaluations
* Use trace for express requests
* Handle sending buffers through evaluation events
* Make event logging a bit more clear
* Fix some errors due to us not actually instantiating until connect/listen
* is this a commit message?
* We can just create the evaluator in the ctor
Not sure what I was thinking.
* memory leak for you, memory leak for everyone
* it's a ternary now
* Don't dispose automatically on close or error
The code may or may not be disposable at that point.
* Handle parsing buffers on the client side as well
* Remove unused protobuf
* Remove TypedValue
* Remove unused forkProvider and test
* Improve dispose pattern for active evals
* Socket calls close after error; no need to bind both
* Improve comment
* Comment is no longer wishy washy due to explicit boolean
* Simplify check for sendHandle and options
* Replace _require with __non_webpack_require__
Webpack will then replace this with `require` which we then provide to
the vm sandbox.
* Provide path.parse
* Prevent original-fs from loading
* Start with a pid of -1
vscode immediately checks the PID to see if the debug process launch
correctly, but of course we don't get the pid synchronously.
* Pass arguments to bootstrap-fork
* Fully implement streams
Was causing errors because internally the stream would set this.writing
to true and it would never become false, so subsequent messages would
never send.
* Fix serializing errors and streams emitting errors multiple times
* Was emitting close to data
* Fix missing path for spawned processes
* Move evaluation onDispose call
Now it's accurate and runs when the active evaluation has actually
disposed.
* Fix promisifying fs.exists
* Fix some active eval callback issues
* Patch existsSync in debug adapter
* Clean up workbench and integrate initialization data
* Uncomment Electron fill
* Run server & client together
* Clean up Electron fill & patch
* Bind fs methods
This makes them usable with the promise form:
`promisify(access)(...)`.
* Add space between tag and title to browser logger
* Add typescript dep to server and default __dirname for path
* Serve web files from server
* Adjust some dev options
* Rework workbench a bit to use a class and catch unexpected errors
* No mkdirs for now, fix util fill, use bash with exec
* More fills, make general client abstract
* More fills
* Fix cp.exec
* Fix require calls in fs fill being aliased
* Create data and storage dir
* Implement fs.watch
Using exec for now.
* Implement storage database fill
* Fix os export and homedir
* Add comment to use navigator.sendBeacon
* Fix fs callbacks (some args are optional)
* Make sure data directory exists when passing it back
* Update patch
* Target es5
* More fills
* Add APIs required for bootstrap-fork to function (#15)
* Add bootstrap-fork execution
* Add createConnection
* Bundle bootstrap-fork into cli
* Remove .node directory created from spdlog
* Fix npm start
* Remove unnecessary comment
* Add webpack-hot-middleware if CLI env is not set
* Add restarting to shared process
* Fix starting with yarn
* Implements the fs module
* Add stats object
* Add not implemented to createWriteStream
* Update mkdtemp to use tmp dir
* Unexport Stats
* Add client web socket for commands and restructure
Asher
John McCambridge
Kyle Carberry