* Create an APIError that should only be used for api returned errors. It'll wrap an error and can have different Kinds and optional code and message. * The http handlers will use the first APIError available in the error chain and generate a json response body containing the code and the user message. The wrapped error is internal and is not sent in the response. If no api error is available in the chain a generic internal server error will be returned. * Add a RemoteError type that will be created from remote services calls (runservice, configstore). It's similar to the APIError but a different type to not propagate to the caller response and it'll not contain any wrapped error. * Gateway: when we call a remote service, by default, we'll create a APIError using the RemoteError Kind (omitting the code and the message that usually must not be propagated). This is done for all the remote service calls as a starting point, in future, if this default behavior is not the right one for a specific remote service call, a new api error with a different kind and/or augmented with the calling service error codes and user messages could be created. * datamanager: Use a dedicated ErrNotExist (and converting objectstorage ErrNotExist).
361 lines
9.7 KiB
Go
361 lines
9.7 KiB
Go
// Copyright 2019 Sorint.lab
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package action
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"time"
|
|
|
|
"agola.io/agola/internal/datamanager"
|
|
"agola.io/agola/internal/db"
|
|
"agola.io/agola/internal/services/configstore/readdb"
|
|
"agola.io/agola/internal/util"
|
|
"agola.io/agola/services/configstore/types"
|
|
|
|
"github.com/gofrs/uuid"
|
|
errors "golang.org/x/xerrors"
|
|
)
|
|
|
|
type OrgMemberResponse struct {
|
|
User *types.User
|
|
Role types.MemberRole
|
|
}
|
|
|
|
func orgMemberResponse(orgUser *readdb.OrgUser) *OrgMemberResponse {
|
|
return &OrgMemberResponse{
|
|
User: orgUser.User,
|
|
Role: orgUser.Role,
|
|
}
|
|
}
|
|
|
|
func (h *ActionHandler) GetOrgMembers(ctx context.Context, orgRef string) ([]*OrgMemberResponse, error) {
|
|
var orgUsers []*readdb.OrgUser
|
|
err := h.readDB.Do(ctx, func(tx *db.Tx) error {
|
|
var err error
|
|
org, err := h.readDB.GetOrg(tx, orgRef)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if org == nil {
|
|
return util.NewAPIError(util.ErrNotExist, errors.Errorf("org %q doesn't exist", orgRef))
|
|
}
|
|
|
|
orgUsers, err = h.readDB.GetOrgUsers(tx, org.ID)
|
|
return err
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
res := make([]*OrgMemberResponse, len(orgUsers))
|
|
for i, orgUser := range orgUsers {
|
|
res[i] = orgMemberResponse(orgUser)
|
|
}
|
|
|
|
return res, nil
|
|
}
|
|
|
|
func (h *ActionHandler) CreateOrg(ctx context.Context, org *types.Organization) (*types.Organization, error) {
|
|
if org.Name == "" {
|
|
return nil, util.NewAPIError(util.ErrBadRequest, errors.Errorf("organization name required"))
|
|
}
|
|
if !util.ValidateName(org.Name) {
|
|
return nil, util.NewAPIError(util.ErrBadRequest, errors.Errorf("invalid organization name %q", org.Name))
|
|
}
|
|
if !types.IsValidVisibility(org.Visibility) {
|
|
return nil, util.NewAPIError(util.ErrBadRequest, errors.Errorf("invalid organization visibility"))
|
|
}
|
|
|
|
var cgt *datamanager.ChangeGroupsUpdateToken
|
|
// changegroup is the org name
|
|
cgNames := []string{util.EncodeSha256Hex("orgname-" + org.Name)}
|
|
|
|
// must do all the checks in a single transaction to avoid concurrent changes
|
|
err := h.readDB.Do(ctx, func(tx *db.Tx) error {
|
|
var err error
|
|
cgt, err = h.readDB.GetChangeGroupsUpdateTokens(tx, cgNames)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// check duplicate org name
|
|
o, err := h.readDB.GetOrgByName(tx, org.Name)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if o != nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("org %q already exists", o.Name))
|
|
}
|
|
|
|
if org.CreatorUserID != "" {
|
|
user, err := h.readDB.GetUser(tx, org.CreatorUserID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if user == nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("creator user %q doesn't exist", org.CreatorUserID))
|
|
}
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
actions := []*datamanager.Action{}
|
|
|
|
org.ID = uuid.Must(uuid.NewV4()).String()
|
|
org.CreatedAt = time.Now()
|
|
orgj, err := json.Marshal(org)
|
|
if err != nil {
|
|
return nil, errors.Errorf("failed to marshal org: %w", err)
|
|
}
|
|
actions = append(actions, &datamanager.Action{
|
|
ActionType: datamanager.ActionTypePut,
|
|
DataType: string(types.ConfigTypeOrg),
|
|
ID: org.ID,
|
|
Data: orgj,
|
|
})
|
|
|
|
if org.CreatorUserID != "" {
|
|
// add the creator as org member with role owner
|
|
orgmember := &types.OrganizationMember{
|
|
ID: uuid.Must(uuid.NewV4()).String(),
|
|
OrganizationID: org.ID,
|
|
UserID: org.CreatorUserID,
|
|
MemberRole: types.MemberRoleOwner,
|
|
}
|
|
orgmemberj, err := json.Marshal(orgmember)
|
|
if err != nil {
|
|
return nil, errors.Errorf("failed to marshal project group: %w", err)
|
|
}
|
|
actions = append(actions, &datamanager.Action{
|
|
ActionType: datamanager.ActionTypePut,
|
|
DataType: string(types.ConfigTypeOrgMember),
|
|
ID: orgmember.ID,
|
|
Data: orgmemberj,
|
|
})
|
|
}
|
|
|
|
// create root org project group
|
|
pg := &types.ProjectGroup{
|
|
ID: uuid.Must(uuid.NewV4()).String(),
|
|
// use same org visibility
|
|
Visibility: org.Visibility,
|
|
Parent: types.Parent{
|
|
Type: types.ConfigTypeOrg,
|
|
ID: org.ID,
|
|
},
|
|
}
|
|
pgj, err := json.Marshal(pg)
|
|
if err != nil {
|
|
return nil, errors.Errorf("failed to marshal project group: %w", err)
|
|
}
|
|
actions = append(actions, &datamanager.Action{
|
|
ActionType: datamanager.ActionTypePut,
|
|
DataType: string(types.ConfigTypeProjectGroup),
|
|
ID: pg.ID,
|
|
Data: pgj,
|
|
})
|
|
|
|
_, err = h.dm.WriteWal(ctx, actions, cgt)
|
|
return org, err
|
|
}
|
|
|
|
func (h *ActionHandler) DeleteOrg(ctx context.Context, orgRef string) error {
|
|
var org *types.Organization
|
|
|
|
var cgt *datamanager.ChangeGroupsUpdateToken
|
|
// must do all the checks in a single transaction to avoid concurrent changes
|
|
err := h.readDB.Do(ctx, func(tx *db.Tx) error {
|
|
var err error
|
|
// check org existance
|
|
org, err = h.readDB.GetOrgByName(tx, orgRef)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if org == nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("org %q doesn't exist", orgRef))
|
|
}
|
|
|
|
// changegroup is the org id
|
|
cgNames := []string{util.EncodeSha256Hex("orgid-" + org.ID)}
|
|
cgt, err = h.readDB.GetChangeGroupsUpdateTokens(tx, cgNames)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// TODO(sgotti) delete all project groups, projects etc...
|
|
actions := []*datamanager.Action{
|
|
{
|
|
ActionType: datamanager.ActionTypeDelete,
|
|
DataType: string(types.ConfigTypeOrg),
|
|
ID: org.ID,
|
|
},
|
|
}
|
|
|
|
_, err = h.dm.WriteWal(ctx, actions, cgt)
|
|
return err
|
|
}
|
|
|
|
// AddOrgMember add/updates an org member.
|
|
// TODO(sgotti) handle invitation when implemented
|
|
func (h *ActionHandler) AddOrgMember(ctx context.Context, orgRef, userRef string, role types.MemberRole) (*types.OrganizationMember, error) {
|
|
if !types.IsValidMemberRole(role) {
|
|
return nil, util.NewAPIError(util.ErrBadRequest, errors.Errorf("invalid role %q", role))
|
|
}
|
|
|
|
var org *types.Organization
|
|
var user *types.User
|
|
var orgmember *types.OrganizationMember
|
|
var cgt *datamanager.ChangeGroupsUpdateToken
|
|
|
|
// must do all the checks in a single transaction to avoid concurrent changes
|
|
err := h.readDB.Do(ctx, func(tx *db.Tx) error {
|
|
var err error
|
|
// check existing org
|
|
org, err = h.readDB.GetOrg(tx, orgRef)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if org == nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("org %q doesn't exists", orgRef))
|
|
}
|
|
// check existing user
|
|
user, err = h.readDB.GetUser(tx, userRef)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if user == nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("user %q doesn't exists", userRef))
|
|
}
|
|
|
|
// fetch org member if it already exist
|
|
orgmember, err = h.readDB.GetOrgMemberByOrgUserID(tx, org.ID, user.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
cgNames := []string{util.EncodeSha256Hex(fmt.Sprintf("orgmember-%s-%s", org.ID, user.ID))}
|
|
cgt, err = h.readDB.GetChangeGroupsUpdateTokens(tx, cgNames)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// update if role changed
|
|
if orgmember != nil {
|
|
if orgmember.MemberRole == role {
|
|
return orgmember, nil
|
|
}
|
|
orgmember.MemberRole = role
|
|
} else {
|
|
orgmember = &types.OrganizationMember{
|
|
ID: uuid.Must(uuid.NewV4()).String(),
|
|
OrganizationID: org.ID,
|
|
UserID: user.ID,
|
|
MemberRole: role,
|
|
}
|
|
}
|
|
|
|
actions := []*datamanager.Action{}
|
|
orgmemberj, err := json.Marshal(orgmember)
|
|
if err != nil {
|
|
return nil, errors.Errorf("failed to marshal project group: %w", err)
|
|
}
|
|
actions = append(actions, &datamanager.Action{
|
|
ActionType: datamanager.ActionTypePut,
|
|
DataType: string(types.ConfigTypeOrgMember),
|
|
ID: orgmember.ID,
|
|
Data: orgmemberj,
|
|
})
|
|
|
|
_, err = h.dm.WriteWal(ctx, actions, cgt)
|
|
return orgmember, err
|
|
}
|
|
|
|
// RemoveOrgMember removes an org member.
|
|
func (h *ActionHandler) RemoveOrgMember(ctx context.Context, orgRef, userRef string) error {
|
|
var org *types.Organization
|
|
var user *types.User
|
|
var orgmember *types.OrganizationMember
|
|
var cgt *datamanager.ChangeGroupsUpdateToken
|
|
|
|
// must do all the checks in a single transaction to avoid concurrent changes
|
|
err := h.readDB.Do(ctx, func(tx *db.Tx) error {
|
|
var err error
|
|
// check existing org
|
|
org, err = h.readDB.GetOrg(tx, orgRef)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if org == nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("org %q doesn't exists", orgRef))
|
|
}
|
|
// check existing user
|
|
user, err = h.readDB.GetUser(tx, userRef)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if user == nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("user %q doesn't exists", userRef))
|
|
}
|
|
|
|
// check that org member exists
|
|
orgmember, err = h.readDB.GetOrgMemberByOrgUserID(tx, org.ID, user.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if orgmember == nil {
|
|
return util.NewAPIError(util.ErrBadRequest, errors.Errorf("orgmember for org %q, user %q doesn't exists", orgRef, userRef))
|
|
}
|
|
|
|
cgNames := []string{util.EncodeSha256Hex(fmt.Sprintf("orgmember-%s-%s", org.ID, user.ID))}
|
|
cgt, err = h.readDB.GetChangeGroupsUpdateTokens(tx, cgNames)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
actions := []*datamanager.Action{}
|
|
actions = append(actions, &datamanager.Action{
|
|
ActionType: datamanager.ActionTypeDelete,
|
|
DataType: string(types.ConfigTypeOrgMember),
|
|
ID: orgmember.ID,
|
|
})
|
|
|
|
_, err = h.dm.WriteWal(ctx, actions, cgt)
|
|
return err
|
|
}
|