From 45a460ebc03822e91b8767b7dc4427bf33b14168 Mon Sep 17 00:00:00 2001 From: Simone Gotti Date: Mon, 8 Jul 2019 09:30:15 +0200 Subject: [PATCH] runservice: handle run not existing Check if the response from the readdb is null and return an http not found error --- internal/services/runservice/api/api.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/internal/services/runservice/api/api.go b/internal/services/runservice/api/api.go index 9eb958e..75667ea 100644 --- a/internal/services/runservice/api/api.go +++ b/internal/services/runservice/api/api.go @@ -396,6 +396,10 @@ func (h *RunHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { http.Error(w, err.Error(), http.StatusInternalServerError) return } + if run == nil { + httpError(w, util.NewErrNotFound(errors.Errorf("run %q doesn't exist", runID))) + return + } cgts, err := types.MarshalChangeGroupsUpdateToken(cgt) if err != nil {